We need to explicitly link to libatomic in order to build with clang.
<img alt="0001-Issue-49400-Add-clang-support-to-rpm-builds.patch" src="/389-ds-base/issue/raw/files/2bc0af51505472748cfebf4098ff6ab8f8d60ef4b9eae833431100d09b021a6a-0001-Issue-49400-Add-clang-support-to-rpm-builds.patch" />
Metadata Update from @vashirov: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Custom field type adjusted to None - Custom field version adjusted to None
Metadata Update from @vashirov: - Custom field reviewstatus adjusted to review (was: None)
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to ack (was: review)
To ssh://pagure.io/389-ds-base.git 7b36a26..7eee594 master -> master
Metadata Update from @vashirov: - Issue assigned to vashirov - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
This patch is breaking COPR builds now on F25 & F26. Perhaps the "buildRequires: libatomics" should be inside the "If clang"?
Interesting, do you have the build logs? And which version (git commit)? It shouldn't affect the gcc build, but I agree that it should be moved to "if clang" section since it's not really needed. I tried latest master and it was built successfully: https://copr.fedorainfracloud.org/coprs/vashirov/389ds/build/637710/
Here it is:
https://copr-be.cloud.fedoraproject.org/results/@389ds/389-ds-base-nightly/fedora-26-x86_64/00633857-389-ds-base/
Spec file doesn't mention libatomic/clang at all: https://copr-be.cloud.fedoraproject.org/results/@389ds/389-ds-base-nightly/fedora-26-x86_64/00633857-389-ds-base/389-ds-base.spec
Ahh, yeah I forgot the copr builds use the upstream spec file and not the one in the source tree. I just updated the upstream spec file and now its building successfully. Sorry for the noise.
Reopening, we need to make the linking of libatomic (-latomic) configurable
Metadata Update from @mreynolds: - Issue assigned to mreynolds (was: vashirov) - Issue status updated to: Open (was: Closed)
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue set to the milestone: 1.4 backlog
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to review (was: ack) - Issue status updated to: Open (was: Closed)
<img alt="0001-Ticket-49400-Make-CLANG-configurable.patch" src="/389-ds-base/issue/raw/files/fdac7c07ce45ea79d919621ca8e233632cf34cde84531d5e41aea33e6bb3c13a-0001-Ticket-49400-Make-CLANG-configurable.patch" />
Metadata Update from @vashirov: - Custom field reviewstatus adjusted to ack (was: review)
b6c1221..8743426 master -> master
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
looks good @mreynolds :)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2459
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.