#49367 missing braces in idsktune
Closed: wontfix 6 years ago Opened 6 years ago by cgrzemba.

Issue Description

there aere 2 missing braces in the Solaris code of function
static void sun_check_network_device(void)

Package Version and Platform

Steps to reproduce

1.
2.
3.

Actual results

Expected results

0029-missing-braces-idsktune.c.patch


Hey mate,

I'm happy to ack/merge this, but just wanted to ask if you mind using git commit/git format-patch to give you correct git log attribution. If you are not bothered, I'll commit this (but it will be under my name)

I see that you are working on solaris components? Are you trying to port 389-ds back onto solaris perhaps?

Thanks,

Metadata Update from @firstyear:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

6 years ago

Please go ahead with mergeing the two issues. Next time I will use git format-path.

why do you say 'back port'? Is Solaris still a supported platform ? ;)
Earlier I packaged 389 DS on opencsw.org, now I try to package on [solaris|oi]-userland.

I will do that then,

The reason I say this is that we have not performed solaris testing in some time. It may be that the project doesn't not 100% operate correctly on Solaris. Especially in the memory/cpu detection areas of the codebase,

I'm happy to help you with your packaging efforts, so I think it would be best to discuss off-ticket. Do you mind emailing 389-devel@lists.fedoraproject.org about your efforts?

commit 978a5777acea41e89a93e717821f567b8525887e
To ssh://git@pagure.io/389-ds-base.git
16aeef6..01272f7 master -> master

Metadata Update from @firstyear:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

6 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2426

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

3 years ago

Login to comment on this ticket.

Metadata
Attachments 1