copied from the Debian bug:
Hi,
389-ds-base FTBFS on various architectures (including armel, i386 and mips) with this error:
[==========] Running 3 test(s). [ RUN ] test_plugin_hello [ OK ] test_plugin_hello [ RUN ] test_plugin_pwdstorage_pbkdf2_auth [ OK ] test_plugin_pwdstorage_pbkdf2_auth [ RUN ] test_plugin_pwdstorage_pbkdf2_rounds [ ERROR ] --- pbkdf2_sha256_calculate_iterations(100000000) == 20000 [ LINE ] --- ../test/plugins/pwdstorage/pbkdf2.c:70: error: Failure! [ FAILED ] test_plugin_pwdstorage_pbkdf2_rounds [==========] 3 test(s) run. [ PASSED ] 2 test(s). [ FAILED ] 1 test(s), listed below: [ FAILED ] test_plugin_pwdstorage_pbkdf2_rounds
This happens because the prototype of the pbkdf2_sha256_calculate_iterations function:
ldap/servers/plugins/pwdstorage/pwdstorage.h 95:PRUint32 pbkdf2_sha256_calculate_iterations();
does not match the type of the definition:
ldap/servers/plugins/pwdstorage/pbkdf2_pwd.c 261:pbkdf2_sha256_calculate_iterations(uint64_t time_nsec)
When the test calls this function with an integer argument, the "default integer promotions" will apply promoting it to an int. Therefore on every architecture where int != uint64_t (pretty much everything), this function call will invoke undefined behavior by having the wrong argument types.
Thanks, James
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873120
Debian 1.3.6.7
Metadata Update from @firstyear: - Issue assigned to firstyear
<img alt="0001-Ticket-49364-incorrect-function-declaration.patch" src="/389-ds-base/issue/raw/files/8506b6c2724c4d9011dc610d02f18cd88a72d7d7efbb6dbed5cec5179a5b1f42-0001-Ticket-49364-incorrect-function-declaration.patch" />
Metadata Update from @firstyear: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to review - Custom field type adjusted to None - Custom field version adjusted to None
thanks, works now
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to ack (was: review)
commit 3f611fc90796042600e01a1a9f24d97f79d7a0ac To ssh://git@pagure.io/389-ds-base.git 16aeef6..01272f7 master -> master
commit c520fb7 To ssh://git@pagure.io/389-ds-base.git 7cf9537..c520fb7 389-ds-base-1.3.6 -> 389-ds-base-1.3.6
Metadata Update from @firstyear: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2423
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.