Through out the code we are inconsistent about our use of sysconf or getdtablesize. We have some defines that are not consistent (such as use_sysconf OR linux) and other places that just look for use sysconf.
We should clean this up,
<img alt="0001-Ticket-49359-sysconf-by-default.patch" src="/389-ds-base/issue/raw/files/5b087a63d01564a03d1cfecb9ddec41ab0e0fed266799511dd7fdd53f9b38966-0001-Ticket-49359-sysconf-by-default.patch" />
Metadata Update from @firstyear: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to review - Custom field type adjusted to None - Custom field version adjusted to None
ok. but now getdtablesize() is no more used and we can completely remove it eg. from
#ifdef SUNOS4
and maybe a lot of stuff in portable.h could be eliminated as well
Yep, I completely agree. I saw a lot that I could cleanup in this area tbh. I've wanted to clean up our portability headers for a while, so maybe I will do that too.
@lkrispen Do you want to ack this as is? Or should I clean all of portable.h in this instead? What do you think?
@lkrispen it sounds like @cgrzemba wants to fix our solaris support, so perhaps this should roll into a portability cleanup? Would you be happy for me to fix that up here?
Metadata Update from @mreynolds: - Issue set to the milestone: 1.4 backlog
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2418
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.