In autotuning we default to a split of 40% to dbcache and 60 to entry. This isn't always the best split, given we cap the dbcache.
In some performance tests I noticed an improvement when increasing the dbcache so I want to propose we change the scaling to 25% split and a cap of 1.5GB.
<img alt="0001-Ticket-49331-change-autoscaling-defaults.patch" src="/389-ds-base/issue/raw/files/d13fdab8bc1998b394f6614362ae36205a57f52b42eb8cb6eb496ac6c40458b0-0001-Ticket-49331-change-autoscaling-defaults.patch" />
Metadata Update from @firstyear: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to review - Custom field type adjusted to None - Custom field version adjusted to None
In the test suite, we have a check for the defaults: https://pagure.io/389-ds-base/blob/master/f/dirsrvtests/tests/suites/config/autotuning_test.py#_88 https://pagure.io/389-ds-base/blob/master/f/dirsrvtests/tests/suites/config/autotuning_test.py#_170
Probably, we need to either adjust the parameters, either rework the tests. I'd say we just adjust the parameters because it is very unlikely that we'll be changing the default hard coded values in DS so often.
Reading the test, it only asserts that a valid value was created, it doesn't check the specifics of that value. As a result the test passes for me with this patch:
18 passed in 131.83 seconds
Reading the test, it only asserts that a valid value was created, it doesn't check the specifics of that value. As a result the test passes for me with this patch: 18 passed in 131.83 seconds
Ok, I was misguided with the parametrization part, my bad. You have my ack. :)
Thanks mate. I'll get @mreynolds or someone else to check the actual server side changes if that's okay (as much as I respect your input :) )
Absolutely. :) I haven't changed the reviewstatus because of that reason.
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to ack (was: review)
commit 708938e To ssh://git@pagure.io/389-ds-base.git 2196614..708938e master -> master
Metadata Update from @firstyear: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2390
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.