#49302 fix test case importst due to lib389 change
Closed: wontfix 6 years ago Opened 6 years ago by firstyear.

Issue Description

A change to lib389 has removed implicit imports through the utils and tasks name spaces.

We need to correct our dirsrvtests to work without these in place.


Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to review
- Custom field type adjusted to defect

6 years ago

I've got a short execution of all tests and there is still an issue somewhere (I haven't checked them all).

For instance,
tests/suites/replication/acceptance_test.py:480: m2.setLogLevel(LOG_DEFAULT)
E NameError: global name 'LOG_DEFAULT' is not defined

I think we need to branch lib389 so tests still pass on 1.3.6 and earlier = toehrwiase need to backport all the CI fixes to previous patches

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.3.7.0

6 years ago

@mreynolds If you branch from commit b5a82795f8f5df3a58bd4c9b87f42dfddf7fefce
that would work.

@spichugi Okay, I'll add that. I wanted to submit this as it's just getting a bit huge as a patch at this point.

Metadata Update from @firstyear:
- Issue assigned to firstyear

6 years ago

I've run all tests and there is the list of missing imports:

dirsrvtests/tests/suites/ds_tools/logpipe_test.py:32 - 'subprocess' is not defined
dirsrvtests/tests/suites/dynamic_plugins/plugin_tests.py:1788 - 'LOCALHOST' is not defined
dirsrvtests/tests/suites/memory_leaks/range_search_test.py:90 - 'VALGRIND_LEAK_STR' is not defined
dirsrvtests/tests/suites/plugins/accpol_test.py:171 - 'subprocess' is not defined
dirsrvtests/tests/suites/replication/acceptance_test.py:486 - 'LOG_DEFAULT' is not defined
dirsrvtests/tests/tickets/ticket47536_test.py:52 - 'DN_DM' is not defined
dirsrvtests/tests/tickets/ticket48226_test.py:111 - 'VALGRIND_LEAK_STR' is not defined
dirsrvtests/tests/tickets/ticket48759_test.py:178 - 'REPLICA_PRECISE_PURGING' is not defined
dirsrvtests/tests/tickets/ticket49121_test.py:193 - 'VALGRIND_INVALID_STR' is not defined

Adds the imports you list as missing. I don't have the ds_tools test folder fyi, so maybe that's local to you.

It is a new commit but it is in repo:
https://pagure.io/389-ds-base/blob/master/f/dirsrvtests/tests/suites/ds_tools/logpipe_test.py

Metadata Update from @spichugi:
- Custom field reviewstatus adjusted to ack (was: review)

6 years ago

commit a8628e2
remote: Sending notification emails to: 389-commits@lists.fedoraproject.org
To ssh://git@pagure.io/389-ds-base.git
7c9c39e..a8628e2 master -> master

Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to review (was: ack)
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

6 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2361

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

3 years ago

Login to comment on this ticket.

Metadata