#49301 CI test - logpipe
Closed: wontfix 2 years ago by mreynolds. Opened 4 years ago by spichugi.

Description

Write (port from TET) namedLogpipe test suite.
Put the tests to suites/ds_tools/logpipe.py


Metadata Update from @spichugi:
- Issue assigned to spichugi

4 years ago

Metadata Update from @spichugi:
- Custom field component adjusted to CI test - suites
- Custom field origin adjusted to QE
- Custom field reviewstatus adjusted to review
- Custom field type adjusted to task
- Custom field version adjusted to 1.3.6

4 years ago

For now, it is one test case only. I need to put it to Upstream Framework because it is easier than to fix it in TET.
I'll put the ds-logpipe.py functionality to lib389 along with unit tests when I'll add the full test suite.

I'm not sure I feel comfortable with this test given it adds a new user. Maybe we should name it dirsrv_testuser to be really clear about it's place? Also, the fixture will fail to run next time if the test fail's because useradd won't be able to create the user. We should check if the user exists, then attempt to add if it does not. :) Hope that helps,

I'm not sure I feel comfortable with this test given it adds a new user. Maybe we should name it dirsrv_testuser to be really clear about it's place? Also, the fixture will fail to run next time if the test fail's because useradd won't be able to create the user. We should check if the user exists, then attempt to add if it does not. :) Hope that helps,

Sure, I agree with dirsrv_testuser, I'll put the change.

Regarding the useradd failure, I don't see much room for the failing test case.
First, if it failed because of the assertion, pytest still will perform all tearDown operation.
Second, if useradd can't add the new user (because the user already exists) it will continue to work, because exception will be just logged. All we need is added user for the test to continue. And dirsrv_testuser is pretty uniq so it won't be some special premisions user (so we don't need to make sure we create new one).

Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to ack (was: review)

4 years ago

16a246a..19b0f43 master -> master
commit 19b0f43
Author: Simon Pichugin spichugi@redhat.com
Date: Tue Jun 27 15:39:25 2017 +0200

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.3.7.0

4 years ago

Metadata Update from @spichugi:
- Assignee reset

2 years ago

Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2360

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

2 years ago

Login to comment on this ticket.

Metadata