#49260 Make log time stamp configurable
Opened 2 years ago by darix. Modified 2 years ago

Currently it is hardcoded to "%d/%b/%Y:%H:%M:%S". I would prefer to also allow iso8601 date/time format.


I would like to see this, but I have two things in mind.

  • We have to change and support both formats in logconv etc, and it may break splunk etc.
  • I don't like config options.

So perhaps if @mreynolds is okay with it, we can change this to be the default in 1.4.x?

Metadata Update from @firstyear:
- Custom field type adjusted to defect

2 years ago

Metadata Update from @firstyear:
- Issue assigned to firstyear

2 years ago

I would like to see this, but I have two things in mind.

We have to change and support both formats in logconv etc, and it may break splunk etc.
I don't like config options.

So perhaps if @mreynolds is okay with it, we can change this to be the default in 1.4.x?

I like adding this "option". However, we should not change the current default behavior format (even in 1.4.x). Too many customers rely on it. This should definitely be a config option - even though William hates new config options :)

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.4 backlog

2 years ago

I really really hate new config options:

First, we open ourselves to customers making mistakes, and this being a format string, that adds a lot of complexity to compile and parse safely.

As well, logconv.pl (or our python) only knows about the "one true format".

IMO it's the path of least resistance to just fix this to use ISO 8601 instead, because at least it's a standard, and makes sense. Everything else is uneccessary work that 99% of our users will never ever ever touch.

Let's just update the default for 1.4.x . It's easier.

" However, we should not change the current default behavior format"

Also, we changed this format in the last 12 months - no one complained at all. I think we can change to 8601 in a major release. :)

" However, we should not change the current default behavior format"

Also, we changed this format in the last 12 months - no one complained at all. I think we can change to 8601 in a major release. :)

I agree, its fine for 1.4.0

Thanks mate. We'll leave this is the ticket queue for then then.

As per design doc http://directory.fedoraproject.org/docs/389ds/design/audit_improvement.html, > the fail log (and audit log) has now the format:

time: 20151111152800

So we should update the audit log timestamp format too.

Metadata Update from @mreynolds:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field version adjusted to None
- Issue tagged with: RFE

2 years ago

Login to comment on this ticket.

Metadata