#49245 1.3.5.x: fix for 48989 broke build on slightly exotic archs
Closed: wontfix 6 years ago Opened 6 years ago by tjaalton.

Issue Description

This commit in 1.3.5.x: 70084f1 Issue 48989 - Overflow in counters and monitor

makes some non-x86 archs use x86 assembly. This obviously breaks the build:

https://buildd.debian.org/status/package.php?p=389-ds-base

which is bad since this I claimed this to be a no-brainer bugfix release that I'd like to get in the next Debian version.

Package Version and Platform

1.3.5.17, Debian


essentially the same error on mips, mipsel, powerpc, powerpcspe, sh4:

../ldap/servers/slapd/slapi_counter.c: In function 'slapi_counter_set_value':
../ldap/servers/slapd/slapi_counter.c:210:5: error: unknown register name 'edx' in 'asm'
asm volatile(
^
../ldap/servers/slapd/slapi_counter.c:210:5: error: unknown register name 'ecx' in 'asm'
../ldap/servers/slapd/slapi_counter.c:210:5: error: unknown register name 'ebx' in 'asm'
../ldap/servers/slapd/slapi_counter.c:210:5: error: unknown register name 'eax' in 'asm'
../ldap/servers/slapd/slapi_counter.c: In function 'slapi_counter_get_value':
../ldap/servers/slapd/slapi_counter.c:277:5: error: unknown register name 'edx' in 'asm'
asm volatile(
^

../ldap/servers/slapd/slapi_counter.c:277:5: error: unknown register name 'ecx' in 'asm'
../ldap/servers/slapd/slapi_counter.c:277:5: error: unknown register name 'ebx' in 'asm'
../ldap/servers/slapd/slapi_counter.c:277:5: error: unknown register name 'eax' in 'asm'
Makefile:8384: recipe for target 'ldap/servers/slapd/libslapd_la-slapi_counter.lo' failed
make[2]: *** [ldap/servers/slapd/libslapd_la-slapi_counter.lo] Error 1

Metadata Update from @firstyear:
- Issue assigned to firstyear

6 years ago

This patch removes the asm from the server code though in favour of the GCC/CLANG __atomic operations. Could you send your config.log from the build?

Metadata Update from @firstyear:
- Custom field type adjusted to defect

6 years ago

I don't have that, because it was built on a buildd. Also slapi_counter.c still has this bit of asm on it.

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.3.5.0

6 years ago

I backported these fixes, but pagure dropped the message :( Here are the commits:

commit 0b5b193
commit abe6d51
commit 0ff9bb3

Metadata Update from @firstyear:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

6 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2304

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

3 years ago

Login to comment on this ticket.

Metadata