389-ds currently supports many libdb versions which are already burried for long time on cemetery for old code. Practically we can assume that noone uses libdb older than 4.7 (which is present in RHEL 6). This change makes various libdb related code more readable and understandable.
389-ds master branch
<img alt="0001-Ticket-49237-Drop-support-for-libdb-older-than-4.7.patch" src="/389-ds-base/issue/raw/files/e94d4e8aaa9621f96c4301ee3db12c29876c5c749205f7db7da5492fbe9622a5-0001-Ticket-49237-Drop-support-for-libdb-older-than-4.7.patch" />
<img alt="0002-Remove-unused-parameter-from-back-ldbm-dblayer.c.patch" src="/389-ds-base/issue/raw/files/c87637e957a488a0f786edb18ab3d7c15b38fec3d6895b4a18b17a325e170e16-0002-Remove-unused-parameter-from-back-ldbm-dblayer.c.patch" />
Hi @atkac, I'll review these for you. Please excuse it may take some time, as I want to apply and run our tests to be sure that these work.
My first inspection of the patches is good, and I think this is really good work. Thanks for the help!
Metadata Update from @firstyear: - Custom field type adjusted to defect
Hey @atkac
I'm having a lot of trouble applying your patches. Would you mind pushing your master branch to a pagure fork / github repo so I can see what you've got for a git history?
Alternately, would you mind rebasing your work onto git master? I suspect your repo content may be out of date. It could be worth checking your git remote settings.
Thanks!
@firstyear Of course, take your time with review.
I pushed my changes to https://pagure.io/fork/atkac/389-ds-base/commits/libdb-cleanup but I think my git settings are correct
$ git remote -v upstream https://pagure.io/389-ds-base.git (fetch) upstream https://pagure.io/389-ds-base.git (push)
$ git fetch upstream
$ git rebase upstream/master Current branch libdb-cleanup is up to date.
$ git log --oneline -3 a14564e Remove unused parameter from back-ldbm/dblayer.c 800158c Ticket 49237: Drop support for libdb older than 4.7 6395357 Ticket 49231 - fix sasl mech handling
and top two commits are attached to this ticket
Thanks mate, I can work with this. I'll review it again now.
I think both of these look good, and I'm happy to ack both. Given the nature of this change, I would like @mreynolds to take a look to, but if he is okay with it, I'll merge this.
I've built it and run some of the test suites on it and they pass (with asan) which is always an excellent sign.
Metadata Update from @firstyear: - Custom field reviewstatus adjusted to review
Metadata Update from @mreynolds: - Issue set to the milestone: 1.3.7.0
Looks good, and passes the base test suite.
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to ack (was: review)
commit c4b896d To ssh://git@pagure.io/389-ds-base.git 620d037..c4b896d master -> master
Thank you so much @atkac for the contribution!
Metadata Update from @firstyear: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2296
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.