Attaching a tentative fix but it has NOT been tested yet.

Seems like a good idea, but there is no "add_entry" flag in plugin_setup().

Why not alter new_plugin_entry to make the dep of the entry as needed, and then to check if we actually need to add the entry?

Under what conditions does this duplication occur? Isn't there a flag that can be put on plugin entries that makes them "hidden" in cn=config somehow?

Thanks William for looking at the patch.
You are right, the 'add_entry' flag was set as 'unused' by https://pagure.io/389-ds-base/issue/49193

int
plugin_setup(Slapi_Entry *plugin_entry, struct slapi_componentid *group,
    slapi_plugin_init_fnptr p_initfunc, int add_entry __attribute__((unused)), char *returntext)

I actually think this flag should be used to not systematically create the plugin entry

@tbordaz - Shouldn't __attribute__((unused)) now be removed from the prototype?

Thanks for your review and advice. I agree prototype should be changed.
Attaching a new patch

One last thing. I don't see how this patch fixes anything. We now check the flag to create the entry, but in every case we set that flag anyway:

ldap/servers/slapd/tools/pwenc.c:                       if (plugin_setup(e, 0, 0, 1, returntext)) 
ldap/servers/slapd/plugin.c:    if((rc = plugin_setup(entry, 0, 0, 1, returntext)) != LDAP_SUCCESS){
ldap/servers/slapd/config.c:                        if (plugin_setup(e, 0, 0, 1, returntext))
ldap/servers/slapd/config.c:                        if (plugin_setup(e, 0, 0, 1, returntext))
ldap/servers/slapd/configdse.c:     retval = plugin_setup(e, 0, 0, 1, returntext);

One last thing. I don't see how this patch fixes anything. We now check the flag to create the entry, but in every case we set that flag anyway:
ldap/servers/slapd/tools/pwenc.c: if (plugin_setup(e, 0, 0, 1, returntext))
ldap/servers/slapd/plugin.c: if((rc = plugin_setup(entry, 0, 0, 1, returntext)) != LDAP_SUCCESS){
ldap/servers/slapd/config.c: if (plugin_setup(e, 0, 0, 1, returntext))
ldap/servers/slapd/config.c: if (plugin_setup(e, 0, 0, 1, returntext))
ldap/servers/slapd/configdse.c: retval = plugin_setup(e, 0, 0, 1, returntext);

Whoops, I found the one place where we don't set it:

ldap/servers/slapd/plugin.c: rc = plugin_setup(e, group_identity, initfunc, 0, returntext);

Nevermind...

@tbordaz Did you attach the new patch ....? I can't see it :(

ohoh !! sorry I forgot to attach it

Thanks Thierry, ack!

Push to master , thanks Mark and William

git push origin master
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 884 bytes | 0 bytes/s, done.
Total 6 (delta 4), reused 0 (delta 0)
To ssh://git@pagure.io/389-ds-base.git
   a771800..8e367dd  master -> master

Thierry I just branched 1.3.6 - can you cherry-pick your fix to 389-ds-base-1.3.6? Thanks!

Thanks Mark for the head up

git push origin 389-ds-base-1.3.6

Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 883 bytes | 0 bytes/s, done.
Total 6 (delta 4), reused 0 (delta 0)
To ssh://git@pagure.io/389-ds-base.git
   e086b83..64ff837  389-ds-base-1.3.6 -> 389-ds-base-1.3.6

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2289

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.