23 passed in 192.05 seconds

64 +      if ((strcmp(attr, "dn") == 0) && (strcmp(val, "cn=config") == 0)) {
65            char *dse_line = NULL;
66 -          
67 -          
68 +          /* Free both outer values and attr */
69 +          free(attr);
70 +          free(val);
71 +          attr = NULL;
72 +          val = NULL;
73 +
74            /* Look for port and rundir attributes */
75            while ((dse_line = ldif_getline(&entryp)) != NULL) {
76                ldif_parse_line(dse_line, &attr, &val, &vlen);
                    <== better check the return value as being done above?
                    <== If failed, report an error and break?
77 @@ -447,6 +461,8 @@ load_config(char *conf_path)
78                    }
79                    got_rundir = 1;
80                }
81 +              free(attr);
82 +              free(val);
                    <== you may want to set NULL to them?
83
84                /* Stop processing this entry if we found the
85                 *  port and rundir and snmp_index settings */
86 @@ -458,6 +474,9 @@ load_config(char *conf_path)
87             * cn=config entry, so we can stop reading through
88             * the dse.ldif now. */
89            break;
90 +      } else {
91 +          free(attr);
92 +          free(val);
                <== you may want to set NULL to them?
93        }
94    }
95

76                          ldif_parse_line(dse_line, &attr, &val, &vlen);

415                 if (ldif_parse_line(ldif_getline(&entryp), &attr, &val, &vlen)) {
416                     printf("ldap-agent: error parsing ldif line from [%s]\n", serv_p->dse_ldif);
417                 }

 75                      while ((dse_line = ldif_getline(&entryp)) != NULL) {
 76                          ldif_parse_line(dse_line, &attr, &val, &vlen);
 77 -                        if (strcmp(attr, "nsslapd-snmp-index") == 0) {
 78 +                        if (attr == NULL || val == NULL) {
 79 +                            /* can't parse these, try next line instead */
 80 +                            continue;