#49206 Add missing build requires on make
Closed: wontfix 6 years ago Opened 6 years ago by firstyear.

Issue Description

During a scripted build I noticed we are missing make from our spec file dependencies. We should correct this.


Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to new
- Custom field type adjusted to defect

6 years ago

Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to review (was: new)

6 years ago

It is not missing in mock because it is installed with group '@buildsys-build'.

But it would be good to ask more experienced fedora packagers whether it should be there. Because there is a note in [1]

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

But link to exceptions does not helped for me. And it also say "Apply common sense" :-)

[1] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines

The reason I wanted to add it is so that we can point to an srpm and just say "here are the dependencies" in a single shot to make it easier for newer developers. Knowing about the @buildsys-build may help, so perhaps I'll add that instead to instructions?

Saying this, the addition also doesn't hurt.

Saying this, the addition also doesn't hurt.

Agree, but consultation with experienced fedora packager will not hurt either :-)

LGTM.
Feel free to push current version.

Mmmm I think I'll just recommend @buildsys-build instead.

Group: Buildsystem building group
 Group-Id: buildsys-build
 Mandatory Packages:
    bash
    bzip2
    coreutils
    cpio
    diffutils
   +epel-release
   +epel-rpm-macros
    findutils
    gawk
   +gcc
   +gcc-c++
    grep
    gzip
    info
    make
    patch
    redhat-rpm-config
    rpm-build
    sed
    shadow-utils
    tar
    unzip
    util-linux
    which
    xz

Metadata Update from @firstyear:
- Issue close_status updated to: invalid
- Issue status updated to: Closed (was: Open)

6 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2265

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: invalid)

3 years ago

Login to comment on this ticket.

Metadata