It is a small progress but pkgconfig files does not work properly if they are installed to non-standard PKG_CONFIG_PATH e.g. /usr/lib/pkgconfig/ on 64 bit machine. In another words, ./configure was not called without any --*dir parameter. BTW Fedora add them all in specfile after expansion of rpm macro "%configure"

sh# cat /usr/lib/pkgconfig/dirsrv.pc 
ldaplib=openldap
Name: dirsrv
Description: 389 Directory Server
Version: 1.3.6.2.20170321git7d1a2ee
Libs: -L${libdir}//dirsrv -lslapd
Cflags: -DUSE_OPENLDAP -I${includedir}//dirsrv
sh# pkg-config --libs dirsrv
Package dirsrv was not found in the pkg-config search path.
Perhaps you should add the directory containing `dirsrv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'dirsrv' found
sh# PKG_CONFIG_PATH=/usr/lib/pkgconfig/ pkg-config --libs dirsrv
Variable 'libdir' not defined in '/usr/lib/pkgconfig/dirsrv.pc'
sh# PKG_CONFIG_PATH=/usr/lib/pkgconfig/ pkg-config --cflags dirsrv
Variable 'libdir' not defined in '/usr/lib/pkgconfig/dirsrv.pc'

ack.

I will update the upstream specfile to use %configure

commit 4fb30a0006518135774c89fca182e79986509f3f
To ssh://git@pagure.io/389-ds-base.git
6ce24c1..4fb30a0 master -> master

commit 4fb30a0 is sufficient enough for fedora but pkgconfig files still need to be fixed.

I don't understand your comment here: What issue still is outstanding you are referring to?

I don't understand your comment here: What issue still is outstanding you are referring to?

@firstyear Check attached patch

Thanks Lukas, I pushed your patch:

25e5b78..b672e63  master -> master
commit b672e63e60d85629e161dbe8c167567dbc08fe22
Author: Lukas Slebodnik <lslebodn@redhat.com>
Date:   Wed Mar 22 16:29:50 2017 +0000

Ahhhh I see, thanks @lslebodn

Patch to fix double slash in pc file

Ack, though I think we should be careful as a change to our configure.ac may break this.

The same bug is also in other pkg-config files.
I would prefer to fix configure script so @serverincdir@ and @serverdir@ will not contain leading '/'

Or another solution is that @serverincdir@ would be full path (including $prefix). But this patch will work as well.

I just wan to give some ideas for improvement :-)

Or another solution is that @serverincdir@ would be full path (including $prefix). But this patch will work as well.
I just wan to give some ideas for improvement :-)

@lslebodn these variables are used in many places in the code so I don't want to meddle with them too much, but I think you'll like this patch. Can you review it please?

@lslebodn these variables are used in many places in the code so I don't want to meddle with them too much, but I think you'll like this patch. Can you review it please?

Sure. You know code much better :-)

All pkgconfig are generated without double slash.

e.g.

prefix=/usr
exec_prefix=/usr
libdir=${exec_prefix}/lib
includedir=${prefix}/include
ldaplib=openldap
Name: dirsrv
Description: 389 Directory Server
Version: 1.3.6.3.20170331git0621e82
Libs: -L${libdir}/dirsrv -lslapd
Cflags: -DUSE_OPENLDAP -I${includedir}/dirsrv

ACK

BTW it is interesting that rpm debuginfo extractor has an issue with '//'. I didn't consider it as any problem in previous reviews.

BTW it is interesting that rpm debuginfo extractor has an issue with '//'. I didn't consider it as any problem in previous reviews.

Yeah I was also surprised to see the double slash cause problems. Oh well, it's fixed now. Thanks for the review!

84ec261..fa5e2d0 master -> master

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2236

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.