When fixing our freeipa cluster & redeploying of some replicas, I hit strange ns-slapd crashes. After little debugging & ASANning, I nailed down double-free in cl5NewDBFile error path. Patch is attached, feel free to ask me if you need more info.
CentOS 7.2
$ rpm -q 389-ds-base 389-ds-base-1.3.5.10-11.x86_64
Crash: $ dmesg -T [Sat Mar 18 20:59:31 2017] traps: ns-slapd[3454] general protection ip:7f2fa2f08abd sp:7f2f787ef560 error:0 in libc-2.17.so[7f2fa2e8d000+1b7000]
ns-slapd shouldn't crash, it should write errors to the log.
<img alt="0001-Fix-double-free-in-_cl5NewDBFile-error-path.patch" src="/389-ds-base/issue/raw/files/d9706a0aae1294884520384b9aa9dd56c0674ebe2559d02bbe7b318bf9cadbdd-0001-Fix-double-free-in-_cl5NewDBFile-error-path.patch" />
Thanks for the patch!! Looks good to me.
314e9ec..13e89e5 master -> master commit 13e89e5 Author: Adam Tkac vonsch@gmail.com Date: Sat Mar 18 23:34:54 2017 +0100
d0d8e6e..798b7e0 389-ds-base-1.3.5 -> 389-ds-base-1.3.5
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to new - Custom field type adjusted to defect - Issue assigned to mreynolds - Issue set to the milestone: 1.3.5.14
Metadata Update from @mreynolds: - Custom field component adjusted to Replication - Custom field origin adjusted to Community - Custom field reviewstatus adjusted to ack (was: new)
Metadata Update from @mreynolds: - Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1433697
Issue linked to Bugzilla: Bug 1433697
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2234
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.