#49171 In some conditions, nunc-stans would report a timeout incorrectly
Closed: wontfix 7 years ago Opened 7 years ago by firstyear.

Issue Description

In some conditions we were not handling timeouts correctly: Especially infinite timeouts.

We should improve our check in daemon.c to check for the idletimeout and warn us if this is occuring. We alter the event output function to give us TIMEOUT | (READ, SIGNAL, WRITE), so that we have a clear barrier between the two.


Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to new
- Custom field type adjusted to defect

7 years ago

Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to review (was: new)

7 years ago

48 + slapi_log_err(SLAPI_LOG_ERR, "ns_handle_pr_read_ready", "Recieved idletime out with c->c_idletimeout as 0. Ignoring.\n");

"received" is spelled wrong, and the indentation in daemon.c is off as well.

I'll assume you'll fix these two minor issues, ack.

Metadata Update from @mreynolds:
- Custom field reviewstatus adjusted to ack (was: review)

7 years ago

And that logging line, should we log a warning instead of an error? SLAPI_LOG_WARN?

commit c8ce1b3
To ssh://git@pagure.io/389-ds-base.git
c75126b..c8ce1b3 master -> master

commit 1d0ff1d
To ssh://git@pagure.io/389-ds-base.git
c8ce1b3..1d0ff1d master -> master

Metadata Update from @firstyear:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1404409

7 years ago

Metadata Update from @firstyear:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2230

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

3 years ago

Login to comment on this ticket.

Metadata