We have a lot of plugin directories in dirsrvtests/tests/suites: dynamic_plugins [PluginName]_plugin - 27 directories While we are in the process of creating tickets for the porting sprint, it would be nice to have an organised structure. As discussed on the Engineering/QE Sync Up meeting we need to move all of them to 'plugins' dir.
Also, as a part of test suites cleanup, we should organise test plans in the docstrings and IDs to an each test case (can be generated with Python 'import uuid; uuid.uuid4()'). create_test.py script should be fixed too and it should check if the ID is unique throughout the tests.
Metadata Update from @spichugi: - Issue assigned to spichugi
Amita, please, review the docstrings part, if the fields work with the Polarion import.
<img alt="0001-Issue-49156-Clean-up-test-suites-dir-structure-and-d.patch" src="/389-ds-base/issue/raw/files/0a0f06b64b6657be75436832cdd41e67dd5b383da2600787a34a7817b2d38602-0001-Issue-49156-Clean-up-test-suites-dir-structure-and-d.patch" />
Metadata Update from @spichugi: - Custom field type adjusted to defect
Metadata Update from @spichugi: - Custom field reviewstatus adjusted to review
ack from me about the reorg of tests, I think we really should improve uor plugin coverage here though.
To ssh://pagure.io/389-ds-base.git f77e777..a51026f master -> master commit a51026f Author: Simon Pichugin spichugi@redhat.com Date: Thu Mar 2 16:53:55 2017 +0100
Metadata Update from @spichugi: - Custom field reviewstatus adjusted to ack (was: review)
ImportError while importing test module '/export/tests/suites/replication/acceptance_test.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: suites/replication/acceptance_test.py:12: in <module> from lib390.topologies import topology_m4 as topo E ImportError: No module named lib390.topologies
<img alt="0001-Issue-49156-Fix-typo-in-the-import.patch" src="/389-ds-base/issue/raw/files/cdbd16bceab30fd3e9ce68795032ef01c3864f127221f7dfdfd1c6fc9b74adc4-0001-Issue-49156-Fix-typo-in-the-import.patch" />
ack
To ssh://pagure.io/389-ds-base.git ef3595d..47cfac8 master -> master commit 47cfac8 Author: Simon Pichugin spichugi@redhat.com Date: Thu Mar 9 13:52:46 2017 +0100
There are some weird characters in the docstrings that prevent byte compiling:
Bytecompiling .py files below /builddir/build/BUILDROOT/389-ds-base-1.3.6.1-20170309git47cfac8.fc25.x86_64/usr/lib/python2.7 using /usr/bin/python2.7 Compiling /builddir/build/BUILDROOT/389-ds-base-1.3.6.1-20170309git47cfac8.fc25.x86_64/usr/lib/python2.7/site-packages/dirsrvtests/tests/suites/paged_results/paged_results_test.py ... Sorry: TypeError: compile() expected string without null bytes
Pagure considers this file a binary: https://pagure.io/389-ds-base/blob/master/f/dirsrvtests/tests/suites/paged_results/paged_results_test.py
<img alt="0001-Issue-49156-Add-more-IDs-and-fix-docstrings.patch" src="/389-ds-base/issue/raw/files/f8e868bd9c2af26e54a63e56cefdf7b7d318c0550f1d619cea21af6533ff9254-0001-Issue-49156-Add-more-IDs-and-fix-docstrings.patch" />
Metadata Update from @spichugi: - Custom field reviewstatus adjusted to review (was: ack)
Your patch appears to be a binary file. Its not readable
Your patch appears to be a binary file. It's not readable I've created it with 'git format-patch -1' and then I've attached it with 'Choose Files'. I did it before like that. Maybe Pagure somehow transform it? Or I do something wrong.
It is downloadable, though, and you can open it with 'vim' afterwards.
It's not readable by some editors that can't handle null byte in the middle of the file. I applied the patch and build was successfull:
+ exit 0 Finish: rpmbuild 389-ds-base-1.3.6.1-20170309git8893cf1.fc24.src.rpm Finish: build phase for 389-ds-base-1.3.6.1-20170309git8893cf1.fc24.src.rpm INFO: Done(dist/srpms/389-ds-base-1.3.6.1-20170309git8893cf1.fc24.src.rpm) Config(fedora-25-x86_64) 4 minutes 41 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-25-x86_64/result Finish: run
Metadata Update from @vashirov: - Custom field reviewstatus adjusted to ack (was: review)
To ssh://pagure.io/389-ds-base.git 47cfac8..57cf1cd master -> master commit 57cf1cd Author: Simon Pichugin spichugi@redhat.com Date: Thu Mar 9 16:47:42 2017 +0100
Metadata Update from @spichugi: - Custom field reviewstatus reset
<img alt="0001-Issue-49156-For-betelgeuse-modified-token-assert-to-.patch" src="/389-ds-base/issue/raw/files/ca71a295853130bc5aa638484cb256ced2f6d3fc462e0e782321f46b3e481b77-0001-Issue-49156-For-betelgeuse-modified-token-assert-to-.patch" />
@spichugi please review.
Please, indent the lines for a proper RST format:
324 + :expectedresults: a. Password expiry warning time should not be returned 325 b. Password expiry warning time should be returned 337 @@ -428,7 +428,7 @@ def test_default_behavior(topology_st, global_policy_default, add_user): 338 2. User entry for binding to the server 339 :steps: 1. Bind as the user 340 2. Request the control for the user 341 - :assert: Password expiry warning time should be returned by the 342 + :expectedresults: Password expiry warning time should be returned by the 343 server by the server since passwordMaxAge and 344 passwordWarning are set to the same value
Also, please, check your commit subject message so it will be proper formed. Basicly, you need to carry about these rules:
Metadata Update from @spichugi: - Custom field reviewstatus adjusted to new
<img alt="0001-Issue-Modify-token-assert-to-expectedresults.patch" src="/389-ds-base/issue/raw/files/a02991daf9c787142bef19860cf46cfd404348c31a6f5930c28cb44c38986f5c-0001-Issue-Modify-token-assert-to-expectedresults.patch" />
@spichugi please check
To ssh://pagure.io/389-ds-base.git 1155d50..092f08a master -> master commit 092f08a Author: Amita Sharma amsharma@redhat.com Date: Mon Mar 27 12:15:45 2017 +0530
Metadata Update from @mreynolds: - Custom field reviewstatus reset (from new) - Issue set to the milestone: 1.3.7.0
Metadata Update from @spichugi: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None - Custom field version adjusted to None - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2215
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Log in to comment on this ticket.