Before we can improve the pblock performance, or fix the target SDN we need to know what is using the pblock correctly.
This means we need to track what accesses are made via the pblock. We can use this information to group exclusive components, and this will allow us to decide what parts can be split up and made exclusive.
attachment 0001-Ticket-49116-Pblock-usage-analytics.patch
This code is disabled by default, and requires DEBUG defined. Passes basic / dynamic tests disabled and enabled.
This has already highlighted a number of places we misuse pblocks and operations.
Looks good, except... many many indentation issues in pblock.c
Metadata Update from @firstyear: - Issue assigned to firstyear - Issue set to the milestone: 1.3.6 backlog
So is that an "ack" or a "please fix the indentation issue"? I think that for now I'm willing to leave the issue given our plan to reformat code base soon ...
Metadata Update from @firstyear: - Custom field reviewstatus adjusted to review (was: review?) - Issue close_status updated to: None
commit 7562c5b6e262d3fe312c5e0d169b93459814f89c To ssh://git@pagure.io/389-ds-base.git 73f221a..6df837c master -> master
With indent fix
Metadata Update from @firstyear: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Compiler warnings: https://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build-warns.1178.txt
I missed this update, I just fixed it with a one line commit...
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2175
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.