Some binaries like
/usr/sbin/ds_removal /usr/sbin/ds_selinux_enabled /usr/sbin/ds_selinux_port_query /usr/sbin/ds_systemd_ask_password_acl /usr/sbin/ds_unregister /usr/sbin/ldap-agent-bin
are not user-runnable, they are executed by other programs instead (setup-ds.pl and ldap-agent). They should not reside in /usr/sbin, since it's used for storing binaries for system administration. Instead they should be placed in /usr/libexec/dirsrv/ which is designed to store binaries that are executed by other programs.
setup-ds.pl
ldap-agent
/usr/libexec/dirsrv/
RPMDiff manpage integrity tests will also be happy.
https://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir
Note: the first 2 belong to 389-admin; the rest does to 389-ds-base. {{{ /usr/sbin/ds_removal - 389-admin /usr/sbin/ds_unregister - 389-admin
/usr/sbin/ds_selinux_enabled - 389-ds-base /usr/sbin/ds_selinux_port_query - 389-ds-base /usr/sbin/ds_systemd_ask_password_acl - 389-ds-base /usr/sbin/ldap-agent-bin - 389-ds-base-snmp }}}
Metadata Update from @nhosoi: - Issue set to the milestone: 1.3.6.0
Metadata Update from @firstyear: - Issue close_status updated to: None - Issue tagged with: Easyfix
Metadata Update from @mreynolds: - Issue set to the milestone: 1.3.7 backlog (was: 1.3.6.0)
Metadata Update from @vashirov: - Issue assigned to vashirov
ldap-agent-bin is no longer present (it was renamed to ldap-agent). Location of ds_s* scripts is addressed in https://pagure.io/389-ds-base/pull-request/49633
Metadata Update from @vashirov: - Custom field reviewstatus adjusted to None
I've checked the PR #49633 and it is seems to work correctly as expected (files are where they should be and basic tests suite runs just ok). However, shouldn't we better put the files into a subdirectory as it is stated in the issue's description (which seems to be preferred according to the Packaging Guidelines, in the form %{_libexecdir}/%{name})?
%{_libexecdir}/%{name}
Yes, you're right, it should be in a separate directory. I've added --libexecdir=%{_libexecdir}/%{pkgname} parameter for configure in the spec file. We should be also updating Fedora/RHEL %configure sections if this is merged.
--libexecdir=%{_libexecdir}/%{pkgname}
Metadata Update from @vashirov: - Custom field reviewstatus adjusted to review (was: None)
Metadata Update from @vashirov: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2165
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.