#49080 shadowExpire should not be a calculated value
Closed: wontfix None Opened 5 years ago by gordonmessmer.

In version 1.3.5, shadowExpire became an attribute whose value was calculated based on the password policy. According to the documentation for the shadow password file (man 5 shadow), this behavior is incorrect. The shadowExpire attribute is not affected by password changes or policies, it is a fixed date on which the account, not the password, will expire.

Please revert this change.

This was discussed on the 389-users list:
https://lists.fedoraproject.org/archives/list/389-users@lists.fedoraproject.org/thread/DMQSDZ2JTVBDGLSYZBW35SWTXHWJTSCH/


Hello, Gordon.

Could you please review the attached patch 0001-Ticket-49080-shadowExpire-should-not-be-a-calculated.patch​? It's almost the same as your original. A compiler warning was additionally fixed. Thanks.

It looks good to me. I didn't notice that exptime wasn't needed until I looked at the rest of the shadow attributes for ticket #49082. This seems like the correct way to handle the required change.

Replying to [comment:4 gordonmessmer]:

It looks good to me. I didn't notice that exptime wasn't needed until I looked at the rest of the shadow attributes for ticket #49082. This seems like the correct way to handle the required change.

Thanks for your quick response! I've sent out a review request to the devel list. Hopefully, we could get some comments soon and take the next step.

Reviewed by Gordon and William (Thanks!!)

Pushed to master:
9835e2b..5a6a5a1 master -> master
commit 14eb192

Pushed to 389-ds-base-1.3.5:
238d3c7..b9e565d 389-ds-base-1.3.5 -> 389-ds-base-1.3.5
commit 2ca12fc

Metadata Update from @nhosoi:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.3.5.14

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2139

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

2 years ago

Login to comment on this ticket.

Metadata