With the ticket https://fedorahosted.org/389/ticket/48752, the cookie value is logged with each page result RESULT. When the page result is completed (no more entry to return), the returned cookie is 'pr_cookie=0'. Else the cookie value is logged 'pr_cookie=<internal index>' Unfortunately the index ranges [0..N].
So when the value pr_cookie=0 is logged, it is not possible to know if it is an empty cookie or a valid cookie with the value 0.
The empty cookie should be logged differently
Hi Thierry, you can use my test case from #48752, it is already at master. dirsrvtests/tests/suites/paged_results/paged_results_test.py::test_multi_suffix_search
Your current patch contains a typo (I think so):
{{{ cookie = 1; }}}
Thanks, Simon
I was adding the same comment a second later you added, Simon! You won. ;)
You are setting 1 in your new proposal 0001-Ticket-48928-log-of-page-result-cookie-should-log-em.patch​, which is conflict with index == 1? Maybe, a typo? Since you wrote this in the comment? :) Log the empty cookie with a value '-1'
You are setting 1 in your new proposal 0001-Ticket-48928-log-of-page-result-cookie-should-log-em.patch​, which is conflict with index == 1? Maybe, a typo? Since you wrote this in the comment? :)
Log the empty cookie with a value '-1'
attachment 0001-Ticket-48928-log-of-page-result-cookie-should-log-em.patch
Thanks, Thierry!
'''git push origin master''' Counting objects: 6, done. Delta compression using up to 8 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 928 bytes | 0 bytes/s, done. Total 6 (delta 4), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git fc97900..73ff835 master -> master
commit 73ff835 Author: Thierry Bordaz tbordaz@redhat.com Date: Mon Jul 18 18:30:28 2016 +0200
Metadata Update from @nhosoi: - Issue assigned to tbordaz - Issue set to the milestone: 1.3.5.12
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1987
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.