#48881 Modifying a VLV attribute is ignored.
Closed: wontfix 3 years ago by mreynolds. Opened 5 years ago by nhosoi.

Modifying a VLV attribute is ignored without any error/warning.

It turned out we intentionally disabled to do so (I guess). Please take a look at the attached diffs.txt, in which the vlv_Modify* callback functions were always returning SLAPI_DSE_CALLBACK_DO_NOT_APPLY. If the value is returned, dse_modify silently skips the primary modify operation itself.

I'd think it was coded like this because modifying VLV attributes are not applied unless reindexing the vlv index. But it's not very nice to ignore the modify without any warnings... I think we should log the modify is being skipped OR we could apply the diffs.txt so that the callback functions return SLAPI_DSE_CALLBACK_OK, and at least the VLV attributes are to be updated.

Currently, this message is logged in the error log:

Modified Virtual List View Search (MCC ou=People dc=example dc=com), which will be enabled when the database is rebuilt.

I think this is good since it indicates the vlv file needs to be reindexed.

Now, which way we should go?
1. returning an error to the client and rejecting the modify.
2. allowing to modify the VLV attributes.


Metadata Update from @nhosoi:
- Issue set to the milestone: 1.3.6 backlog

5 years ago

Metadata Update from @mreynolds:
- Issue close_status updated to: None
- Issue set to the milestone: 1.3.7 backlog (was: 1.3.6 backlog)

5 years ago

Metadata Update from @mreynolds:
- Issue set to the milestone: FUTURE (was: 1.3.7 backlog)

4 years ago

Metadata Update from @mreynolds:
- Custom field reviewstatus adjusted to None
- Issue assigned to mreynolds
- Issue set to the milestone: 1.4.0 (was: FUTURE)

3 years ago

Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

3 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1940

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

2 years ago

Login to comment on this ticket.

Metadata