As we are about to release, we should check and run pep8 on our code. There are also some other rpm fixes needed for distribution, so we should basically have a tidy up before we release the next version.
Part 1, fixes for tests 0001-Ticket-48878-pep8-fixes-and-fix-rpm-to-build.patch
Part 2, complete fixes for pep8 on all other modules. 0001-Ticket-48878-pep8-fixes-part-2.patch
All lib389 tests pass under python 2 with these changes.
Part 3, take mbasti's advice. 0001-Ticket-48878-better-style-for-backend-in-backend_tes.patch
Need all 3 patches.
commit 81d7eab894851020b3dd605a9dd4d462c813eef8 commit 3de8e61812b823fee995452f9603ebf15811388b commit 67e09b5573368b1b162f7ef0d2ee996f2a69fef3 Writing objects: 100% (61/61), 10.43 KiB | 0 bytes/s, done. Total 61 (delta 55), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/lib389.git 1c09a99..24f7d8d master -> master
Metadata Update from @firstyear: - Issue assigned to firstyear - Issue set to the milestone: lib389 1.0.2
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1937
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Log in to comment on this ticket.