#48863 Remove vmsize from util size check
Closed: wontfix None Opened 7 years ago by firstyear.

On x86_64 this value is inconsistent. On 32bit it's always low, and shouldn't be checked. I suspect this is the same on ppc64.

Remove it, and use pages properly from memtotal.


Looks good to me.

One trivial thing... This comment could puzzle future readers since there is just one item "pages" now. ;)
{{{
1647 1641 / Pages is the total ram on the system. We should smaller of:
1648 * - vmsize
1649 1642 * - pages
1650 1643
/
}}}

I updated the comment in the commit, no code changes.

commit 133be4f61d6cf2283612927953e97a7ff8ba8fdf

Total 15 (delta 11), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
11f55f3..0f4f838 master -> master

Metadata Update from @firstyear:
- Issue assigned to firstyear
- Issue set to the milestone: 0.0 NEEDS_TRIAGE

7 years ago

Metadata Update from @vashirov:
- Issue set to the milestone: None (was: 0.0 NEEDS_TRIAGE)

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1923

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata