#48850 Memory Leaks: pwdhash-bin, and ns-slapd.
Closed: Fixed None Opened 3 years ago by firstyear.

A number of memory leaks were detected on my system.

Direct leak of 2392 byte(s) in 13 object(s) allocated from:
    #0 0x7f623165ff30 in calloc (/lib64/libasan.so.3+0xc6f30)
    #1 0x7f6231107d08 in slapi_ch_calloc /home/wibrown/development/389ds/ds/ldap/servers/slapd/ch_malloc.c:188
    #2 0x7f6231136e39 in slapi_entry_alloc /home/wibrown/development/389ds/ds/ldap/servers/slapd/entry.c:1957 //
    #3 0x7f623113312d in str2entry_dupcheck /home/wibrown/development/389ds/ds/ldap/servers/slapd/entry.c:802 //
    #4 0x7f623113524f in slapi_str2entry /home/wibrown/development/389ds/ds/ldap/servers/slapd/entry.c:1346
    #5 0x403362 in slapd_config /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:336
    #6 0x402357 in init_config /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:114
    #7 0x4029b0 in main /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:204
    #8 0x7f622e42d230 in __libc_start_main (/lib64/libc.so.6+0x20230)

Direct leak of 312 byte(s) in 13 object(s) allocated from:
    #0 0x7f623165ff30 in calloc (/lib64/libasan.so.3+0xc6f30)
    #1 0x7f6231107d08 in slapi_ch_calloc /home/wibrown/development/389ds/ds/ldap/servers/slapd/ch_malloc.c:188
    #2 0x7f62311f48c0 in generate_componentid /home/wibrown/development/389ds/ds/ldap/servers/slapd/plugin.c:4118
    #3 0x7f62311f0731 in plugin_setup /home/wibrown/development/389ds/ds/ldap/servers/slapd/plugin.c:3008
    #4 0x40343e in slapd_config /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:353
    #5 0x402357 in init_config /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:114
    #6 0x4029b0 in main /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:204
    #7 0x7f622e42d230 in __libc_start_main (/lib64/libc.so.6+0x20230)


Direct leak of 11 byte(s) in 1 object(s) allocated from:
    #0 0x7f6b030e3120 in strdup (/lib64/libasan.so.3+0x5a120)
    #1 0x7f6b02bf7e0e in slapi_ch_strdup /home/wibrown/development/389ds/ds/ldap/servers/slapd/ch_malloc.c:217
    #2 0x7f6afa5dfbfb in ns_mta_md5_pwd_storage_scheme_init /home/wibrown/development/389ds/ds/ldap/servers/plugins/pwdstorage/pwd_init.c:310
    #3 0x7f6b02ce091e in plugin_setup /home/wibrown/development/389ds/ds/ldap/servers/slapd/plugin.c:3035
    #4 0x40349d in slapd_config /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:356
    #5 0x4023a7 in init_config /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:114
    #6 0x402a00 in main /home/wibrown/development/389ds/ds/ldap/servers/slapd/tools/pwenc.c:204
    #7 0x7f6afff1d230 in __libc_start_main (/lib64/libc.so.6+0x20230)

This corrects some of the longstanding leaks we have had in our server which caused some valgrind false positives.


Your patch looks good to me.

commit 2e5f0ff
Writing objects: 100% (9/9), 1.60 KiB | 0 bytes/s, done.
Total 9 (delta 7), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
b36a315..2e5f0ff master -> master

Metadata Update from @nhosoi:
- Issue assigned to firstyear
- Issue set to the milestone: 1.3.5.5

2 years ago

Login to comment on this ticket.

Metadata