For some tests we need to be able to pause and unpause replication agreements. This wraps this to make it a bit easier.
attachment 0001-Ticket-48819-Add-pause-and-unpause-to-replica-agreem.patch
Hi William, wouldn't it be more convenient to put these methods to '''agreement.py'''?
Also, what do you think about putting some return statement there? At least we can return something like this:
{{{ return self.conn.modify_s(agmtdn, mod) }}}
Thanks, Simon
commit 47b9a51c013225790b575dd03a01b8944c589139 Total 9 (delta 6), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/lib389.git 0289b4a..47b9a51 master -> master
Hi William,
as I see, you closed this ticket with commit from #48434. And those patch doesn't contain changes from this ticket patch.
Also I've found "resume" and "pause" feature within agreement.py module. https://git.fedorahosted.org/cgit/389/lib389.git/tree/lib389/agreement.py#n652
So there is no need to implement that once again at replica.py. I think we can leave it as closed.
Ohhh I'm so sorry. I made a mistake here! I commited without ack. I'll check to see what I did wrong, and will clean it up.
Sorry!
Metadata Update from @firstyear: - Issue assigned to firstyear - Issue set to the milestone: 0.0 NEEDS_TRIAGE
Metadata Update from @vashirov: - Issue set to the milestone: None (was: 0.0 NEEDS_TRIAGE)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1879
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.