#48795 Update create_test.py
Closed: Fixed None Opened 4 years ago by mreynolds.

ds/dirsrvtests/create_test.py needs to be updated. Currently replication agreement names are not properly formatted which breaks MMR setups. There are other minor updates that need to be done as well.


Hi Mark,

your patch looks good to me. Thank you for the create_test.py enhancement!

Only one '''REALLY MINOR''' thing.
If we are talking about PEP8, then doctrings(PEP257) should look like that:

{{{
"""Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

not like that:
{{{
"""
Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

Thanks,
Simon

Replying to [comment:2 spichugi]:

Hi Mark,

your patch looks good to me. Thank you for the create_test.py enhancement!

Only one '''REALLY MINOR''' thing.
If we are talking about PEP8, then doctrings(PEP257) should look like that:

{{{
"""Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

not like that:
{{{
"""
Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

Thanks,
Simon

Yeah that's just a personal preference of mine of to do it that way, but I will change it. Thanks!

5601fe4..17f30c6 master -> master
commit 17f30c6
Author: Mark Reynolds mreynolds@redhat.com
Date: Fri May 20 17:22:01 2016 -0400

d5a84c4..b69db2a 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit b69db2a

42ba838..0b98840 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit 0b98840

Metadata Update from @mreynolds:
- Issue assigned to mreynolds
- Issue set to the milestone: CI test 1.0

3 years ago

Login to comment on this ticket.

Metadata