$ fgrep -n fp ../BUILD/389-dsgw-1.1.11/config.c | egrep "fopen|fclose" 254: if (( fp = fopen( filename, "r" )) == NULL ) { 1503: } else if (NULL == (fp = fopen (fname, "r"))) { 1531: fclose (fp); $
Suggest add missing call to fclose.
Thanks for the diff, dcb.
Could it be possible to generate the diff in the git patch format and attach it to this ticket?
We will push your patch to the git repository. Thanks!
All new to me, I am guessing something like
$ diff -u config.c.sav config.c --- config.c.sav 2016-04-21 19:46:51.784050350 +0100 +++ config.c 2016-04-21 19:49:48.290511584 +0100 @@ -789,6 +789,7 @@ filename, lineno ); } } + fclose(fp);
if (!gc->gc_haveaimschema) { gc->gc_aimpresence = 0; /* can't have aim presence without aim schema */
$
might be suitable.
Metadata Update from @nhosoi: - Issue set to the milestone: 389-dsgw 1.1.12
DSGW is deprecated, closing ticket
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to None (was: needinfo) - Issue close_status updated to: wontfix - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1846
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Login to comment on this ticket.