#48750 Cleanup lib389 log messages around commands
Closed: wontfix None Opened 6 years ago by firstyear.

Clean up the lib389 log messages around commands so that it's a cleaner user experience.


Hi William,

I think it is great that you've decided to clean up our logs. But, unfortunately, a lot of lib389 tests fail with your patch.
I think the main reason is that you've deleted "CONF_PRODUCT_NAME" from lib389/_constants.py.

Can you please fix tests too and include changes to your patch? Just be sure that all of them are still pass. :)

Thanks,
Simon

Hi,

I didn't find anywhere that used it, which is why I removed it. I've put it back now.

Sorry about the confusion.

Thanks, all tests PASS. Looks good to me. Ack.

commit d33624108669bafa12acd46b4544fee329933fda
To ssh://git.fedorahosted.org/git/389/lib389.git
543f868..d336241 master -> master

Metadata Update from @spichugi:
- Issue assigned to firstyear
- Issue set to the milestone: lib389 1.0.2

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1810

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

2 years ago

Login to comment on this ticket.

Metadata