As seen in the report, SYNTAX OID value is in single quotes, which is not valid and no longer supported. (gdb) print at_berval[859]->bv_val $28 = 0x7f0c80073950 "( 2.16.840.1.113730.3.1.612 NAME 'generation' DESC 'Netscape defined attribute type' SYNTAX '1.3.6.1.4.1.1466.115.121.1.26' X-ORIGIN 'Netscape Directory Server' )"
But the server should not crash.
Instead of LDAPDebug1Arg which gets compiled out, can we use one of the slapi_log_error functions?
Otherwise a visual check looks good to me.
Looks good to me too.
Replying to [comment:3 firstyear]:
Instead of LDAPDebug1Arg which gets compiled out, can we use one of the slapi_log_error functions? Otherwise a visual check looks good to me. Thank you for reviewing the patch. I'm curious. Are there any particular reason why we'd better call slapi_log_error? It is a macro of "slapd_log_error_proc( NULL, fmt, arg );" We are using lots of LDAPDebug*. Are they to be replaced eventually?
Otherwise a visual check looks good to me. Thank you for reviewing the patch. I'm curious. Are there any particular reason why we'd better call slapi_log_error? It is a macro of "slapd_log_error_proc( NULL, fmt, arg );" We are using lots of LDAPDebug*. Are they to be replaced eventually?
git patch file (master) -- replaced LDAPDebug macro with slapi_log_error 0001-Ticket-48492-heap-corruption-at-schema-replication.patch
Reviewed by William and Mark (Thanks!!)
Pushed to master: 75b545a..b5bfa2a master -> master commit b5bfa2a
Pushed to 389-ds-base-1.3.4: 099883c..9bd53c2 389-ds-base-1.3.4 -> 389-ds-base-1.3.4 commit 9bd53c2
(In reply to German Parente from comment #49)
It's enough to use a particular custom schema and enable: nsslapd-enquote-sup-oc: on I will give more details later today.
It's enough to use a particular custom schema and enable:
nsslapd-enquote-sup-oc: on
I will give more details later today.
Indeed, the schema code is adding the single quotes if the config param is on. {{{ slap.h:#define CONFIG_ENQUOTE_SUP_OC_ATTRIBUTE "nsslapd-enquote-sup-oc" outp += put_tagged_oid( outp, "SYNTAX ", syntaxoid, syntaxlengthbuf, aew->enquote_sup_oc ); }}} The case needs to be covered, as well.
I haven't run this code, but visually it looks okay.
git patch file (master) -- additinal fixes for the crash and better nsslapd-enquote-sup-oc support 0001-Ticket-48492-heap-corruption-at-schema-replication.2.patch
Some minimal testing done, looks good to me.
Reviewed by William (Thank you!!)
Pushed to master: 6186290..955dc66 master -> master commit 955dc66
Pushed to 389-ds-base-1.3.4: 957dfe1..7927e44 389-ds-base-1.3.4 -> 389-ds-base-1.3.4 commit 7927e44
Metadata Update from @nhosoi: - Issue assigned to nhosoi - Issue set to the milestone: 1.3.4.10
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1774
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.