#48353 Add Replication REST support to lib389
Closed: Fixed None Opened 3 years ago by mreynolds.

Add support for the replication resources in rest389. This also requires completing some unfinished aspects of lib389's replication code.


Hi Mark,

I ran our tests '''tests/agreement_test.py''' and '''tests/replica_test.py''' with your patch.

  • '''tests/agreement_test.py''' went with a new error about REPLICA_BINDDN

{{{
if REPLICA_BINDDN not in properties:
E TypeError: argument of type 'NoneType' is not iterable
}}}

  • '''tests/replica_test.py''' is not working well at all. (without your patch too)

As I see, your patch changed a way of working with replicas. Can you take a look at tests, please?
Or describe its new way here and I will fix test suites by myself.

Replying to [comment:2 spichugi]:

Hi Mark,

I ran our tests '''tests/agreement_test.py''' and '''tests/replica_test.py''' with your patch.

  • '''tests/agreement_test.py''' went with a new error about REPLICA_BINDDN

{{{
if REPLICA_BINDDN not in properties:
E TypeError: argument of type 'NoneType' is not iterable
}}}

  • '''tests/replica_test.py''' is not working well at all. (without your patch too)

So replica_test never worked? I also see a bunch of bugs in agreement_test.py (that were previously there).

As I see, your patch changed a way of working with replicas. Can you take a look at tests, please?
Or describe its new way here and I will fix test suites by myself.

Sorry I did not look in /tests. I'm also in the process of redoing that patch for other issues spotted by William. So I'll make sure this gets addressed. I know the current version of my new patch(that you do not have) passes the replication tests in dirsrvtests/tickets in the 389 source code.

New patched. Tests in lib389 and 389ds now pass.

83d5e37..2ea4218 master -> master
commit 2ea421830cd5b27607b0e98b90bd2cbdf69a5483
Author: Mark Reynolds mreynolds@redhat.com
Date: Mon Nov 23 20:40:38 2015 -0500

Milestone lib389 1.0 deleted

Metadata Update from @mreynolds:
- Issue assigned to mreynolds

2 years ago

Login to comment on this ticket.

Metadata