#48345 lib/libadminutil/psetc.c:201: possible bad test ?
Closed: Fixed None Opened 3 years ago by dcb.

[lib/libadminutil/psetc.c:201]: (warning) Char literal compared with pointer 'target.attrName'. Did you intend to dereference it?

Source code is

if (target->attrName && target->attrName != '\0') PR_Free(target->attrName);

Maybe better source code

if (target->attrName && target->attrName[0] != '\0') PR_Free(target->attrName);

Fix provided by dcb - Thanks!

3c704bd..3253bef master -> master
commit 3253bef42151cbef479a3a08e50066da0f60c952
Date: Thu Jun 30 14:13:18 2016 -0400

Metadata Update from @mreynolds:
- Issue assigned to mreynolds
- Issue set to the milestone: 389-admin,console 1.1.44

2 years ago

Login to comment on this ticket.