#48273 lib389 - valgrind functions need improvement
Closed: wontfix None Opened 6 years ago by mreynolds.

Currently the valgrind function valgrind_check_leak() looks at the process output(ps -ef), then stops the server, and looks at the output. This means that you can only can this function once, all future checks will fail since the process was stopped. Check leaks should not stop the server or check the the process output for the valgrind output file. The output file should be gathered after valgrind is enabled, and before we check for leaks, so it can be checked multiple times. The server should also not be stopped when checking for leaks.

The wiki page for lib389 valgrind testing will need to be amended once a fix is done.


git patch file (master) -- CI test for #48226 - additional check for a memory leak.
ticket48226_test.diffs.txt

Hi Mark, thanks for the valgrind enhancement. Could you please add the diff to the patch?
Then, you have my ack.

Actually, it revealed another leak in #48226... I'm reopening the ticket...

Replying to [comment:2 nhosoi]:

Hi Mark, thanks for the valgrind enhancement. Could you please add the diff to the patch?
Then, you have my ack.

New patch attached with your revisions.

Thanks,
Mark

Thank you, Mark! Ack'ed.

Lib389

To ssh://git.fedorahosted.org/git/389/lib389.git
8c5376d..c7651ff master -> master
commit c7651ff66211caab60e3ac79c2c89c5e1eb91c9f
Author: Mark Reynolds mreynolds@redhat.com
Date: Tue Sep 15 18:14:59 2015 -0400

389-ds-base

To ssh://git.fedorahosted.org/git/389/ds.git
2311c71..c2e350e master -> master
commit c2e350e
Author: Mark Reynolds mreynolds@redhat.com
Date: Tue Sep 15 23:12:01 2015 -0400

5f32582..5165d58 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit 5165d58

16bd6af..c7ac0ad 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit c7ac0ad

Metadata Update from @mreynolds:
- Issue assigned to mreynolds
- Issue set to the milestone: CI test 1.0

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1604

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

a year ago

Login to comment on this ticket.

Metadata