#48257 Fix coverity issues - 08/24/2015
Closed: wontfix None Opened 8 years ago by nhosoi.

13310 Untrusted value as argument /builddir/build/BUILD/389-ds-base-1.3.5.a1/ldap/servers/slapd/daemon.c (slapd_daemon)
13174 Unchecked return value      /builddir/build/BUILD/nunc-stans-0.1.5...c/ringbuffer/ringbuffer_get_and_put.c (ringbuffer_get_read_element)
13173 Side effect in assertion    /builddir/build/BUILD/nunc-stans-0.1.5/liblfds/src/slist/slist_link.c (slist_internal_link_element)
13175 Side effect in assertion    /builddir/build/BUILD/nunc-stans-0.1.5/liblfds/src/slist/slist_link.c (slist_internal_link_element)
13176 Side effect in assertion    /builddir/build/BUILD/nunc-stans-0.1.5/liblfds/src/slist/slist_link.c (slist_internal_link_element)

13310 is taken care in the Ticket #48339 - Share nsslapd-threadnumber in the case nunc-stans is enabled, as well.

I'm happy with this. When NDEBUG is defined, assert(expr) always returns 0, so we are not changing the operation of the program at all. Ack from me.

Reviewed by William (Thanks!!)

Pushed to master:
74387ee..eda8482 master -> master
commit 4b9a54f7ba5f78b0402c0695998cca049ea3f095

git patch file (master) -- patch to fix the regression provided by Lukas Slebodnik lslebodn@redhat.com (Thanks!!)
0001-Ticket-48257-Fix-coverity-issues-08-24-2015.2.patch

Pushed to master:
eda8482..5b03995 master -> master
commit c290fdc046dcb61aa36591c72720c9b43adee533

Metadata Update from @nhosoi:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.3.5.0

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1588

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata