#48251 Improve the basic test suite
Closed: wontfix None Opened 6 years ago by spichugi.

We have new standards for the pytest code writing.
https://fedorahosted.org/389/ticket/48242

So before making some changes, we should refactor and improve existing code.

Time for the basic test suite: "dirsrvtests/suites/basic/basic_test.py".


Can you also add this minor fix(that addresses false failures):

{{{
@@ -596,12 +596,13 @@ def test_basic_systemctl(topology):
log.info('Server failed to start as expected')

 #
  • Fix the dse.ldif, nad make sure the server starts up,

  • Fix the dse.ldif, and make sure the server starts up,

    # and systemctl correctly identifies the successful start
    #
    shutil.copy(tmp_dir + 'dse.ldif', config_dir)
    log.info('Starting the server...')
    rc = os.system(start_ds)

  • time.sleep(10)
    }}}

Thanks

{{{
615 def test_basic_ldapagent(topology):
616 '''
617 Test that the ldap agnet starts
618 '''
644 def test_basic_ldapagent(topology, import_example_ldif):
645 """Test that the ldap agnet starts"""

}}}

Looks like you copied my typo, it should be agent, not agnet. Everything else looks good

71987ed..ee96ec7 master -> master
commit ee96ec7
Author: Simon Pichugin spichugi@redhat.com
Date: Wed Aug 19 17:46:10 2015 +0200

73d7dcf..326f73f 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit 326f73f
Author: Simon Pichugin spichugi@redhat.com
Date: Wed Aug 19 17:46:10 2015 +0200

Metadata Update from @mreynolds:
- Issue assigned to spichugi
- Issue set to the milestone: CI test 1.0

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1582

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

a year ago

Login to comment on this ticket.

Metadata