If your access log has been rotated away, there is no way to identify the IP address of the client. For example, if all you have is:
[29/Jun/2015:10:52:04 -0600] conn=130 op=299348283 SRCH base="dc=localhost,dc=localdomain" scope=2 filter="(objectClass=*)" attrs=ALL
you can't go back in the access log and get the fd and the ip address.
In addition, the cn=monitor connection attribute only lists the fd, not the connection number. So it is difficult to figure out which connection in the cn=monitor corresponds to conn=130. Even if you figure out which one it is, it is difficult to get the client IP address given the fd - you have to use tcpdump or some combination of /proc/$pid/fd/$fd and /proc/net/tcp. We should somewhere list the connection number and client IPv4/IPv6 address. If we can't use the existing cn=monitor connection attribute because that would break backwards compatibility, which should list it somewhere else.
A good idea! We should have it. Which version do we need this enhancement? 1.3.4 or 1.3.5?
Replying to [comment:1 nhosoi]:
It would be nice to have in 1.3.4, but not necessary. 1.3.5 is fine.
Per triage, push the target milestone to 1.3.6.
Metadata Update from @rmeggins: - Issue set to the milestone: 1.3.6.0
Metadata Update from @mreynolds: - Issue assigned to mreynolds
Metadata Update from @mreynolds: - Issue close_status updated to: None - Issue set to the milestone: 1.3.7 backlog (was: 1.3.6.0)
<img alt="0001-Ticket-48210-Add-IP-addr-and-connid-to-monitor-outpu.patch" src="/389-ds-base/issue/raw/c3aa5d2923ad3f69730c353137befeeaa20d69bc9e0ff28179b7c91786539b46-0001-Ticket-48210-Add-IP-addr-and-connid-to-monitor-outpu.patch" />
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to review
Hey mate,
59 +» » » int lenip = ct->c[i].c_ipaddr ? strlen(ct->c[i].c_ipaddr) : 0;
Strlen returns a size_t, so I think you should avoid int here. As well, use of int isn't good, we should use the inttypes (int32_t, int64_t) etc to be clear about our requirements. Same is true of lenconn I think here.
Otherwise it looks good. I don't like the ternary but that's just me because I have a really hard time reading them :(
<img alt="0001-Ticket-48210-Add-IP-addr-and-connid-to-monitor-outpu.patch" src="/389-ds-base/issue/raw/9e19ef498ec40ecb29764c0399d4f8556970b132822f8fc03f84953eb2f119fc-0001-Ticket-48210-Add-IP-addr-and-connid-to-monitor-outpu.patch" />
Revisions made....
Perfect! Thanks so much! ack from me,
Metadata Update from @firstyear: - Custom field reviewstatus adjusted to ack (was: review)
Thanks!
b23201b..4940c5f master -> master
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue set to the milestone: 1.3.7.0 (was: 1.3.7 backlog) - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1541
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.