#48203 Fix coverity issues - 07/14/2015, 07/07/2015, 06/22/2015
Closed: wontfix None Opened 5 years ago by nhosoi.

13294   Uninitialized scalar variable -- retrocl_init_trimming (introduced by #47669)
13293   Resource leak -- retrocl_init_trimming (introduced by #47669)

2. Defect type: CHECKED_RETURN
   50. ldap/servers/slapd/tools/ldclt/ldapfct.c:1945:
   9.  ldap/servers/slapd/tools/ldclt/ldapfct.c:952:
       check_return: Calling "addErrorStat" without checking return value
       (as is done elsewhere 26 out of 28 times).

1. Defect type: COMPILER_WARNING
   2.  ldap/servers/slapd/daemon.c:1412:21:
       warning: 'tp' may be used uninitialized in this function
       [-Wmaybe-uninitialized]

nack - looks like you have some unrelated formatting changes in this patch?

Replying to [comment:2 rmeggins]:

nack - looks like you have some unrelated formatting changes in this patch?

Yeah, I did it to ldap/servers/slapd/tools/ldclt/ldapfct.c... I thought it was harmless, but not?

Replying to [comment:3 nhosoi]:

Replying to [comment:2 rmeggins]:

nack - looks like you have some unrelated formatting changes in this patch?

Yeah, I did it to ldap/servers/slapd/tools/ldclt/ldapfct.c... I thought it was harmless, but not?

Makes it difficult to backport/cherry pick this patch. I know - it is hard to resist the urge to fix bad formatting . . .

Thank you for reviewing the patch, Rich!

Pushed to master:
09ab8c7..df13210 master -> master
commit 32d45c7

Pushed to 389-ds-base-1.3.4:
fb89fb0..923a7ff 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit 97da9cb

git patch file (master) -- a dereference of a null pointer (connection_table_get_connection)
0001-Ticket-48203-Fix-coverity-issues-07-07-2015.patch

Thanks to Rich for the discussion and his reviewing the patch.

Pushed to master:
6306fc4..bca0908 master -> master
commit bca0908

Pushed to 389-ds-base-1.3.4:
5bd7119..a741911 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit a741911

ldap/servers/slapd/tools/ldclt/threadMain.c:489:
overrun-local: Overrunning array "mctx.negativeErrors" of 19 4-byte elements at element index 122 (byte offset 488) using index "abs(err)" (which evaluates to 122).

Reviewed by Rich (Thank you!!)

Pushed to master:
f69ce33..cc435b8 master -> master
commit cc435b8

Pushed to 389-ds-base-1.3.4:
ca9e6f9..6ec1001 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit 6ec1001

Metadata Update from @rmeggins:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.3.4.2

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1534

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

9 months ago

Login to comment on this ticket.

Metadata