#48146 async simple paged results issue
Closed: Fixed None Opened 4 years ago by nhosoi.

Problem scenario:
1) Send a simple paged results search requests asynchronously.
2) Repeat the request with the same cookie before the first request is returned.
3) The intenal search result object held by the thread for the second request could be destroyed when the first request completes.


With the patch: 0001-Ticket-48146-async-simple-paged-results-issue.patch
1) Passed 40 hour stress test
2) Passed acceptance tests

Thanks to Rich and Mark for their discussions and reviews.

Pushed to master:
19d8b63..947477f master -> master
commit 947477f

Pushed to 389-ds-base-1.3.3:
1dbce48..ec8801a 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit ec8801a

Pushed to 389-ds-base-1.3.2:
422c9cd..c4ab119 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit c4ab119

Pushed to 389-ds-base-1.2.11:
8d46178..31cd2a5 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 31cd2a5

git patch file (master) -- need to close a small window for a pr index competed among multiple threads
0001-Ticket-48146-async-simple-paged-results-issue-need-t.patch

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-log-pr.patch​ added
git patch file (master) -- log pr index in access log

ack

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-need-t.patch​ added
This scares me - if it is somehow possible to deref the 0x1 pointer, boom - crash.

Replying to [comment:9 rmeggins]:

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-log-pr.patch​ added
git patch file (master) -- log pr index in access log

ack

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-need-t.patch​ added
This scares me - if it is somehow possible to deref the 0x1 pointer, boom - crash.

Understood... How about the next patch? I'm running the test with it now...

git patch file (master) -- revised patch for "need to close a small window for a pr index competed among multiple threads"
0001-Ticket-48146-async-simple-paged-results-issue-need-t.2.patch

Rich, thank you for reviewing the patches!

Pushed to 389-ds-base-1.3.3:
650ca94..8e21bfb 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit 9eb20d8
commit 3cf85d1
commit 8e21bfb

Pushed to 389-ds-base-1.3.2:
c4ab119..644a116 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit b123fae
commit 85d105e
commit 644a116

Pushed to 389-ds-base-1.2.11:
31cd2a5..82020ad 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 0bff700
commit 38efd17
commit 82020ad

Closing this ticket when the patches are pushed to the master branch.

Pushed to master:
cd9afbb..4051fe0 master -> master
commit 09c730b
commit 5e9c4f1
commit 4051fe0

git patch file (master) -- fixing a regression introduced by the previous commit
0001-Ticket-48146-async-simple-paged-results-issue.2.patch

Reviewed by Mark (Thank you!!!)

Pushed to master:
eb46e6f..bd2c0d0 master -> master
commit bd2c0d0

Pushed to 389-ds-base-1.3.3:
03bee0a..0c7b38a 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit 0c7b38a

Pushed to 389-ds-base-1.3.2:
46242d8..2003d79 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit 2003d79

Pushed to 389-ds-base-1.2.11:
164cb24..52a7299 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 52a7299

git patch file (master) -- fixing a regression introduced by the commit 5e9c4f1
0001-Ticket-48146-async-simple-paged-results-issue.3.patch

Reviewed by Mark (Thank you!!)

Pushed to master:
bd2c0d0..03d3455 master -> master
commit 03d3455

Pushed to 389-ds-base-1.3.3:
0c7b38a..f6fe5bf 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit f6fe5bf

Pushed to 389-ds-base-1.3.2:
2003d79..64b54d4 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit 64b54d4

Pushed to 389-ds-base-1.2.11:
52a7299..b500958 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit b500958

Metadata Update from @nhosoi:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.2.11.33

2 years ago

Login to comment on this ticket.