#48136 accept auxilliary objectclasse in replication agreements
Closed: wontfix None Opened 7 years ago by lkrispen.

the agmt_modify-callback checks the applied modifications and accepts only changes for some attributes.
IPA needs to add information to the repl agreement (topology management) which would be provided with a new objectclass. This should be accepted as it does not interfere with normal repl configuration.

Looks good except you have a free that is not needed:

207 for (i = 0; NULL != mods && NULL != mods[i]; i++) {
208 char *val = NULL;
209 if (strcasecmp(mods[i]->mod_type, "objectclass")) continue;
210 if (mods[i]->mod_bvalues){
211 int j;
212 slapi_ch_free_string(&val); --> val is always NULL, why free it?

good catch. the declaration of val and the final free should be outside the for loop, inside it should sstay to free the val of the previous iteration. I will fix it and resend

committed to master:
commit fd81643
Author: Ludwig Krispenz lkrispen@redhat.com
Date: Tue Mar 31 10:15:08 2015 +0200

committed to 1.3.3:
commit 891d4ce
Author: Ludwig Krispenz lkrispen@redhat.com
Date: Tue Mar 31 10:15:08 2015 +0200

Metadata Update from @lkrispen:
- Issue assigned to lkrispen
- Issue set to the milestone:

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1467

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

2 years ago

Login to comment on this ticket.