Constants look good, ack,
Test data is good, but maybe do we want to change the copyright or add the RH cr?
The tests look good (I need to run them in the future). With the names FXX, could these be made more descriptive perhaps?
Otherwise, happy to ack,
Thanks for so massive work. It is really impressive! :)
So I've tested your patch.
First, I think you can add the required ldifs to '''dirsrvtests/tests/data/filter''' dir along with the commit.
Next, your patch fails for now, because of the bind user credentials. You have '''BINDUSER_PW = 'password'''', but every user was added with its own password.
dn: uid=ashelton, ou=People, dc=example,dc=com
I guess you have changed all userpassword at '''filter.ldif''' in your environment? With that it will pass.
And one more thing. Can you please move '''CERT_USER1=''' and '''CERT_USER2=''' to some cert files at '''dirsrvtests/tests/data/filter''' too. It will look better there and will make code more readable.
contains these changed passwords
Metadata Update from @lkrispen:
- Issue assigned to lkrispen
- Issue set to the milestone: CI test 1.0
Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)
to comment on this ticket.