Metadata Update from @nhosoi: - Issue set to the milestone: CI test 1.0
Adding bugzilla tests
<img alt="0001-ds_logs-tests-bugzilla-tests.patch" src="/389-ds-base/issue/raw/files/c7e002893fb17fc71d159ba98dc209872b922d8c90455e819a57ba1501ad16cd-0001-ds_logs-tests-bugzilla-tests.patch" />
Metadata Update from @sramling: - Custom field reviewstatus adjusted to None - Issue close_status updated to: None
Metadata Update from @sramling: - Custom field reviewstatus adjusted to review (was: None)
Thanks for the patch, Sankar.
Could you please use regression_test.py?
We use DEFAULT_SUFFIX in topology, not SUFFIX, though they are the same for now, it can be that some values can be changed later. So let's stick to one.
We have loglevels here - https://pagure.io/lib389/blob/master/f/lib389/_constants.py#_218 In my opinion, it is better not to hardcode values but use those from lib389. And you can use them directly in mark.parametrize, no need to put into another variable in the beginning of the file.
And one more issue. I think descriptions are not clear enough. See the comments:
# I think, we need to name tests not "what we do", but "what we test" in regression tests # So it is not "test_error_log_reset", but something like "test_default_loglevel_stripped" def test_error_log_reset(topo, log_level): # The same here. Something like: "test_dse_config_loglevel_error" instead of "test_dse_error_log" def test_dse_error_log(topo): # It is not precise enough. The error occurs only for 64 — Config file processing """ Manually setting nsslapd-errorlog-level in dse.ldif throws error :id: 0eeefa17-ec1c-4208-8e7b-44d8fbc38f10 :feature: Logging :setup: Standalone instance :steps: 1. Stop the server, edit dse.ldif file and change nsslapd-errorlog-level value to 64 2. Start the server and observe the error logs. :expectedresults: 1. Server should be successfully stopped and nsslapd-errorlog-level value should be changed. 2. Server should be successfully started without any errors being reported in the logs.
Patch is updated.
<img alt="0001-ds_logs-bugzilla-tests.patch" src="/389-ds-base/issue/raw/files/67fd386dbe4fddf56a2da1c8a6b5f43489998c7cccdab2efba6af427f5ac1806-0001-ds_logs-bugzilla-tests.patch" />
commit 8965a8f Author: Sankar Ramalingam sramling@redhat.com Date: Mon Aug 21 21:17:00 2017 +0530
Metadata Update from @spichugi: - Custom field reviewstatus adjusted to ack (was: review)
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1398
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)
Login to comment on this ticket.