#48056 CI test - basic
Closed: wontfix 4 years ago by mreynolds. Opened 9 years ago by nhosoi.

Is this ticket completed?


Just basic.sh was ported, but there were other tests in the "acceptance" directory in TET that were not ported: ipv6, stress, some acl test, etc. So just asking about the "basic" suite, then yes it is completed.

Metadata Update from @mreynolds:
- Issue set to the milestone: CI test 1.0

7 years ago

Metadata Update from @sramling:
- Custom field reviewstatus adjusted to None
- Issue close_status updated to: None

6 years ago

Metadata Update from @sramling:
- Custom field reviewstatus adjusted to review (was: None)

6 years ago

I've seen the conversation on IRC, so I'll just sum up main points:

  1. A test that focused on 'cn=config' should be in 'dirsrvtests/tests/suites/config/config_test.py';
  2. You need a proper docstring for every test case you write. It should contain: a description, feature, setup, steps, expectedresults;
  3. Please, use 'config.set()' instead of direct ldap calls (for the most operations we have a distinct module like config, backend, replica, etc.)
  4. If you use try-except blocks, use them around the exact place where an error can happen (it should be explicit, not around two lines). Plus, in your case, you can skip it. If error will happen, it will show you the place in the stack trace and the execution will continue with a next test.

@spichugi , thanks for your review comments. I am working on reproducing the bugzilla with the steps given, but couldn't succeed. @vashirov , If I can't reproduce the issue, I will keep this work on hold and move on to other tasks. Thanks again for reminding me things...

I am not going ahead with the patch since the issue is not reproducible.

Metadata Update from @sramling:
- Custom field reviewstatus adjusted to None (was: review)

6 years ago

commit 9225222
Author: Amita Sharma amsharma@redhat.com
Date: Wed Aug 16 18:59:18 2017 +0530

@spichugi https://pagure.io/389-ds-base/pull-request/49872 please review. (ongoing work for basic test suit migration)

Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1387

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

3 years ago

Login to comment on this ticket.

Metadata