Add "valgrind" functions so memory leaks can easily be tested
Cool!
So, when checking, we could just pass, e.g., the questionable function name to leak_str? May I ask you to allow a regex str there if easy? ;) valgrind_check_leak(dirsrv_inst, leak_str):
Replying to [comment:2 nhosoi]:
Cool! So, when checking, we could just pass, e.g., the questionable function name to leak_str?
So, when checking, we could just pass, e.g., the questionable function name to leak_str?
Currently that's how it works.
May I ask you to allow a regex str there if easy? ;)
That should be quite easy, thanks for the suggestion. I also want to add a default valgrind wrapper for ns-slapd to lib389 itself- instead of requiring a wrapper be provided from the dirsrv test. I'll send out a new patch for review once this is all done.
So, when checking, we could just pass, e.g., the questionable function name to leak_str? May I ask you to allow a regex str there if easy? ;)
Okay, new patch is attached.
Thanks A LOT, Mark!!!
revision #2 0001-Ticket-48028-lib389-add-valgrind-functions.patch
To ssh://git.fedorahosted.org/git/389/lib389.git 8d0eba7..f857a38 master -> master commit f857a3892b1bd5ec8463ce21e04101764af18e09 Author: Mark Reynolds mreynolds@redhat.com Date: Wed Feb 11 09:13:48 2015 -0500
Add valgrind wrapper for ns-slapd 0001-Ticket-48028-add-valgrind-wrapper-for-ns-slapd.patch
Last push was missing the valgrind ns-slapd wrapper:
To ssh://git.fedorahosted.org/git/389/lib389.git f857a38..6a733eb master -> master commit 6a733ebbe16f106a23b7685033376821ca7775dc
Milestone lib389 1.0 deleted
Metadata Update from @mreynolds: - Issue assigned to mreynolds
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1359
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.