#48019 Remove constants.py and the topology backup/restore from all the 389 ticket test scripts
Closed: Fixed None Opened 4 years ago by mreynolds.

Remove constants.py from ds/dirsrvtests/tickets, and all references to it from all the ticket tests. lib389's "_constants.py" now contains everything, and more, than what was in /ds/dirsrvtests/tickets/constants.py.

The backup/restore functionality in the topology function, designed to speed up restarting a ticket, is problematic when running all the ticket tests(via py.test). There is not much performance gain, if any, by using these backups, and due to the problems is creates it should be removed.


With this patch all the tests pass(suites and tickets)

{{{
ds/dirsrvtests/py.test -v

======================================================= test session starts ========================================================
platform linux2 -- Python 2.7.5 -- pytest-2.4.2 -- /usr/bin/python
collected 182 items

suites/basic/basic_test.py:69: test_basic PASSED
suites/basic/basic_test.py:131: test_basic_final PASSED
suites/dynamic-plugins/test_dynamic_plugins.py:74: test_dynamic_plugins PASSED
suites/dynamic-plugins/test_dynamic_plugins.py:457: test_dynamic_plugins_final PASSED
suites/schema/test_schema.py:153: test_schema_comparewithfiles PASSED
suites/schema/test_schema.py:192: test_schema_final PASSED
tickets/ticket47313_test.py:64: test_ticket47313_run PASSED
tickets/ticket47313_test.py:142: test_ticket47313_final PASSED
tickets/ticket47462_test.py:141: test_ticket47462 PASSED
tickets/ticket47462_test.py:341: test_ticket47462_final PASSED
...
...
tickets/ticket47988_test.py:216: test_ticket47988_init PASSED
tickets/ticket47988_test.py:334: test_ticket47988_1 PASSED
tickets/ticket47988_test.py:345: test_ticket47988_2 PASSED
tickets/ticket47988_test.py:384: test_ticket47988_3 PASSED
tickets/ticket47988_test.py:395: test_ticket47988_4 PASSED
tickets/ticket47988_test.py:414: test_ticket47988_5 PASSED
tickets/ticket47988_test.py:434: test_ticket47988_6 PASSED
tickets/ticket47988_test.py:474: test_ticket47988_final PASSED

================================================== 182 passed in 1341.82 seconds ===================================================
}}}

f68e2d4..d602e30 master -> master
commit d602e30
Author: Mark Reynolds mreynolds@redhat.com
Date: Thu Jan 29 21:47:19 2015 -0500

Milestone lib389 1.0 deleted

Metadata Update from @mreynolds:
- Issue assigned to mreynolds

2 years ago

Login to comment on this ticket.

Metadata