#47927 Uniqueness plugin: should allow to exclude some subtrees from its scope
Closed: wontfix None Opened 6 years ago by tbordaz.

As reported by https://fedorahosted.org/freeipa/ticket/4636, configuration using only uniqueness-subtrees introduces some constraints.

In the described use case, it would be more rapid to define uniqueness-subtrees-exclude from part of the DIT that should not be enforced

The IPA ticket ‚Äčhttps://fedorahosted.org/freeipa/ticket/4636 is related to 'Views'.
'Views' are targeted for Freeipa 4.1 which is going to be RHEL 7.1

Alexander plans to work on this improvement together with tbordaz.

Attached is the first cut to add exclude subtrees.

Hello Alexander,

The fix looks good.
Just a remark in search_one_berval. I think that if one of the retrieved entry is part of an excluded subtree, it should rather continue to test the others entries than report LDAP_SUCCESS.


It does continue to the other entries, it only skips this entry because of the excluded match. This is a nested loop and a break within the nested one only brings you to the outer loop, not out of it.

Alexander, you are right, no concern regarding search_one_berval.

Hi Alexander,

I'm afraid uid.c had been modified and your patch fails to apply by "git am". Could it be possible to rebase with master on your checked out branch and recreate a patch? If you have the right to push the patch, please go ahead and do so. If not, we will do it.

Thanks Rich for the review

'''push to master'''

Updating cd8614a..cd9afbb
dirsrvtests/tickets/ticket47823_test.py | 13 ++--
dirsrvtests/tickets/ticket47927_test.py | 300 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
ldap/servers/plugins/uiduniq/uid.c | 97 +++++++++++++++++++++-----
3 files changed, 389 insertions(+), 21 deletions(-)
create mode 100644 dirsrvtests/tickets/ticket47927_test.py

git push origin master
Counting objects: 20, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 4.01 KiB, done.
Total 11 (delta 8), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
cd8614a..cd9afbb master -> master

commit cd9afbb
Author: Thierry Bordaz tbordaz@redhat.com
Date: Tue Apr 28 19:35:34 2015 +0200

Metadata Update from @tbordaz:
- Issue assigned to abbra
- Issue set to the milestone: 1.3.4 backlog

3 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1258

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

2 months ago

Login to comment on this ticket.