#47918 result of dna_dn_is_shared_config is incorrectly used
Closed: Fixed None Opened 4 years ago by lkrispen.

The function dna_dn_is_shared_config() should determine if the entry handled by the plugin is a shared config entry, but it does the opposite.
As a side effect for every changed entry dna_load_shared_servers() is called.


In my opinion it should be:
--- a/ldap/servers/plugins/dna/dna.c
+++ b/ldap/servers/plugins/dna/dna.c
@@ -4163,7 +4163,7 @@ static int dna_config_check_post_op(Slapi_PBlock * pb)
if (dna_dn_is_config(dn)) {
dna_load_plugin_config(pb, 0);
}
' - if(dna_dn_is_shared_config(pb, dn) == 0){
' + if(dna_dn_is_shared_config(pb, dn)) {
dna_load_shared_servers();
}
}

$ git merge ticket47918
Updating 4711de6..32aa172
Fast-forward
ldap/servers/plugins/dna/dna.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
$ git push origin master
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 790 bytes, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git

$ git cherry-pick 32aa172
[389-ds-base-1.3.3 8d96791] Ticket 47918 - result of dna_dn_is_shared_config is incorrectly used
1 file changed, 1 insertion(+), 1 deletion(-)
$ git push origin 389-ds-base-1.3.3
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 791 bytes, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
1bf510c..8d96791 389-ds-base-1.3.3 -> 389-ds-base-1.3.3

$ git cherry-pick 32aa172
[389-ds-base-1.3.2 b2e24bb] Ticket 47918 - result of dna_dn_is_shared_config is incorrectly used
1 file changed, 1 insertion(+), 1 deletion(-)
$ git push origin 389-ds-base-1.3.2
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 798 bytes, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
f9eed02..b2e24bb 389-ds-base-1.3.2 -> 389-ds-base-1.3.2

$ git cherry-pick 32aa172
[389-ds-base-1.3.1 c26a7b1] Ticket 47918 - result of dna_dn_is_shared_config is incorrectly used
1 file changed, 1 insertion(+), 1 deletion(-)
$ git push origin 389-ds-base-1.3.1
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 786 bytes, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
46051b4..c26a7b1 389-ds-base-1.3.1 -> 389-ds-base-1.3.

Metadata Update from @lkrispen:
- Issue assigned to lkrispen
- Issue set to the milestone: 1.3.3 - 10/31 (October)

2 years ago

Login to comment on this ticket.

Metadata