lib389 tasks currently do not include back and restore tasks.
Nice functions.
you may add functions description with @param, @return, @raise so that we will be able to generate lib389 automatically.
in db2bak/bak2db, I would rather use 'cn = strftime("%m%d%Y_ %H%M%S", time.localtime())' than time.time() that does not give an explicit date. You may check that backup_dir exists and raise an exception if not
revision 0001-Ticket-47845-Add-backup-restore-fixup-tombstone-task.patch
Made the suggested changes, and added the tombstone fixup task. New patch attached...
Changes look good. Ack
(Just a small remark in fixupTombstone, you may catch ldap.already_exist during the add of task and then return -1)
Replying to [comment:6 tbordaz]:
Changes look good. Ack (Just a small remark in fixupTombstone, you may catch ldap.already_exist during the add of task and then return -1)
Change made, and added that error check to the existing memberOf task.
2cb056a..5cd2ce5 master -> master commit 5cd2ce5a394b888ba888479c36bd21262be6d4f7
Add option for stripping csn 0001-Ticket-47845-add-stripcsn-option-to-tombstone-fixup-.patch
Added option to strip csns - used to verify fix up
6fd3473..c0401ed master -> master commit c0401ed4e3bb94a66795c28e580c92b8adbe3382
Metadata Update from @mreynolds: - Issue assigned to mreynolds - Issue set to the milestone: N/A
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1176
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.