DNA generate/assign attributes value only if the target entry is in a configured scope(DNAscope).
There is no way to exclude subtrees that are under the DNAscope. For example, we want the plugin to be active on all entries under SUFFIX except the entries under 'cn=provisioning,SUFFIX'.
It should introduce a new config attribute: DNAexcludeSubtree. This new attribute should be multivalued, DN syntax.
This enhancement is required for https://fedorahosted.org/freeipa/ticket/3813, where DNA should scope SUFFIX except 'Stage' and 'Delete' entries (under cn=provisioning,SUFFIX)
attachment 0001-Ticket-47828-test-case.patch
attachment 0001-Ticket-47828-DNA-scope-allow-to-exlude-some-subtrees.patch
Please add dnaExcludeScope to 10dna-plugin.ldif
Also update the internal schema OID repo:
git clone ssh://code.engineering.redhat.com/rhanana.git
Thanks, Mark
attachment 0002-Ticket-47828-DNA-scope-allow-to-exlude-some-subtrees.patch
Overall, looks good to me. One question... Where is the dnaExcludeScope attributeTypes defined? Why just objectClases in 10dna-plugin.ldif?
Other than that, you have my ack.
attachment 0002-Ticket-47828-test-case.patch
attachment 0003-Ticket-47828-DNA-scope-allow-to-exlude-some-subtrees.patch
Noriko,
Thank you so much for the review. Actually you were right I booked the oid for dnaExcludeScope in rhanana but forgot to add its declaration in 10dna-plugin.ldif. So I modified the fix with this new declaration.
In addition, I fixed a couple of problems in the testcase.
Thank you, Thierry!!
'''Push to Master'''
git merge ticket47828 Updating 6dcc12c..b43e899 Fast-forward dirsrvtests/tickets/ticket47828_test.py | 721 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ldap/schema/10dna-plugin.ldif | 8 + ldap/servers/plugins/dna/dna.c | 73 ++++++++- 3 files changed, 801 insertions(+), 1 deletion(-) create mode 100644 dirsrvtests/tickets/ticket47828_test.py
git push origin master Counting objects: 22, done. Delta compression using up to 4 threads. Compressing objects: 100% (12/12), done. Writing objects: 100% (12/12), 5.45 KiB, done. Total 12 (delta 9), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 6dcc12c..b43e899 master -> master
git push origin '''389-ds-base-1.3.3'''
Counting objects: 22, done. Delta compression using up to 4 threads. Compressing objects: 100% (12/12), done. Writing objects: 100% (12/12), 5.44 KiB, done. Total 12 (delta 9), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 50f3f5a..74834a2 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
Fix testcase issue:
d774b19..4606c8b master -> master commit 4606c8b Author: Mark Reynolds mreynolds@redhat.com Date: Tue May 19 16:46:47 2015 -0400
14e2e34..148e510 389-ds-base-1.3.3 -> 389-ds-base-1.3.3 commit 148e510
Fix import issue with testcase 0001-Ticket-47828-fix-testcase-import-issue.patch
Metadata Update from @mreynolds: - Issue assigned to tbordaz - Issue set to the milestone: 1.3.3 backlog
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/1159
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.