#47767 Nested tombstones become orphaned after purge
Closed: wontfix None Opened 10 years ago by mreynolds.

When tombstone purging occurs it will remove a parent tombstone, which leaves any child tombstone entries orphaned.


Mark, your patch looks good to me.
I have one question. This op flag OP_FLAG_REVERSE_CANDIDATE_ORDER is available to the ldap clients? E.g., could it be set with Simple Paged Results or Server Side Sorting? I guess it's a pure internal operation, but I'd like to have a confirmation...

Replying to [comment:2 nhosoi]:

Mark, your patch looks good to me.
I have one question. This op flag OP_FLAG_REVERSE_CANDIDATE_ORDER is available to the ldap clients? E.g., could it be set with Simple Paged Results or Server Side Sorting? I guess it's a pure internal operation, but I'd like to have a confirmation...

The flag can only be set using the slapi api. So it will work for plugins, etc, but not remote ldap clients(C SDK, etc). We would need to create a new LDAP control for remote clients in this case. Sounds like a good candidate for a new ticket.

The sort control has a reverse flag. But I'm not sure how to map an attribute type specified in the sort control to a "candidate". I suppose entryid?

Replying to [comment:3 mreynolds]:

Replying to [comment:2 nhosoi]:

Mark, your patch looks good to me.
I have one question. This op flag OP_FLAG_REVERSE_CANDIDATE_ORDER is available to the ldap clients? E.g., could it be set with Simple Paged Results or Server Side Sorting? I guess it's a pure internal operation, but I'd like to have a confirmation...

The flag can only be set using the slapi api. So it will work for plugins, etc, but not remote ldap clients(C SDK, etc). We would need to create a new LDAP control for remote clients in this case. Sounds like a good candidate for a new ticket.

Thanks! I'm ack'ing...

git merge ticket47736
Updating 559d70e..ce23d5d
Fast-forward
ldap/servers/plugins/replication/repl5_replica.c | 8 +++-
ldap/servers/slapd/back-ldbm/idl_common.c | 6 +++
ldap/servers/slapd/back-ldbm/ldbm_delete.c | 8 +++-
ldap/servers/slapd/back-ldbm/ldbm_search.c | 47 +++++++++++++++++++++-
ldap/servers/slapd/back-ldbm/proto-back-ldbm.h | 1 +
ldap/servers/slapd/operation.c | 1 +
ldap/servers/slapd/slap.h | 1 +
ldap/servers/slapd/slapi-plugin.h | 8 ++--
ldap/servers/slapd/slapi-private.h | 44 +++++++++++---------
9 files changed, 95 insertions(+), 29 deletions(-)

git push origin master
559d70e..ce23d5d master -> master

commit ce23d5d
Author: Mark Reynolds mreynolds@redhat.com
Date: Tue Apr 8 14:12:32 2014 -0400

12dc759..0ddf772 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit 0ddf772

4d5eaa5..203970e 389-ds-base-1.3.1 -> 389-ds-base-1.3.1
commit 203970e7ee8350a5d805895daf2f8884934c25b9

ffb8903..48e2a96 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 48e2a96

Metadata Update from @nhosoi:
- Issue assigned to mreynolds
- Issue set to the milestone: 1.2.11.30

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1099

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata