#47710 Missing warning for invalid replica backoff configuration
Closed: wontfix None Opened 10 years ago by nhosoi.

Description of problem:
In the scenarios where nsds5ReplicaBackoffMin > nsds5ReplicaBackoffMax, an
error/warning is logged to indicate the inconsistency. The warning is not
displayed when nsds5ReplicaBackoffMax is set to zero. (The default value is
used.)

Version-Release number of selected component (if applicable):
389-ds-base-1.3.1.6-18.el7

Steps to Reproduce:
1. Set up a replica
2. Configure the attributes such as nsds5ReplicaBackoffMin >
nsds5ReplicaBackoffMax and nsds5ReplicaBackoffMax == 0
3. Start the instance/Trigger the replication backoff

Actual results:
The warning is not logged.

Expected results:
The warning is logged.


Copy and Paste error ;) type_replicaBackoffMin at the line 1853 should be Max...
{{{
1851 backoff_max = slapi_entry_attr_get_int(e, type_replicaBackoffMax);
1852 if(backoff_max <= 0){
1853 if(backoff_max != 0) {
1853 if(slapi_entry_attr_exists(e, type_replicaBackoffMin)){
1854 backoff_max = slapi_entry_attr_get_int(e, type_replicaBackoffMax);
1855 if(backoff_max <= 0){
}}}

Replying to [comment:7 nhosoi]:

Copy and Paste error ;) type_replicaBackoffMin at the line 1853 should be Max...
{{{
1851 backoff_max = slapi_entry_attr_get_int(e, type_replicaBackoffMax);
1852 if(backoff_max <= 0){
1853 if(backoff_max != 0) {
1853 if(slapi_entry_attr_exists(e, type_replicaBackoffMin)){
1854 backoff_max = slapi_entry_attr_get_int(e, type_replicaBackoffMax);
1855 if(backoff_max <= 0){
}}}

Thanks for catching for this! New patch attached.

git merge ticket47710
Updating 068ee18..eb5fde9
Fast-forward
ldap/servers/plugins/replication/repl5_replica.c | 21 +++++++++++++--------
ldap/servers/slapd/entry.c | 12 +++++++++++-
ldap/servers/slapd/slapi-plugin.h | 10 ++++++++++

git push origin master
068ee18..eb5fde9 master -> master

commit eb5fde9
Author: Mark Reynolds mreynolds@redhat.com
Date: Tue Jul 15 12:34:02 2014 -0400

Metadata Update from @nhosoi:
- Issue assigned to mreynolds
- Issue set to the milestone: 1.3.3 - 8/14 (August)

7 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1045

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

3 years ago

Login to comment on this ticket.

Metadata